Speed up profiling first pass #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* print out columns so users see something happening rather than waiting
jcampbell
requested changes
Aug 1, 2019
| for column in df.get_table_columns(): | ||
| columns = df.get_table_columns() | ||
| number_of_columns = len(columns) | ||
| for i, column in enumerate(columns): |
There was a problem hiding this comment.
Adding column-level info here really increases the verbosity of the overall output, but I do like having the names of the columns present.
Outside the CLI module, we route all such messages through the logger. So two changes requested here: change the print statement to a log output, and ensure you don't use f-string style formatting to maintain py2 compatibility.
There was a problem hiding this comment.
It definitely increases the verbosity which is IMO far batter than indeterminate silence. Eventually I'd like to see a progress bar so this is a small step in that direction.
There was a problem hiding this comment.
Fixed both recommendations!
* proper logger for output
jcampbell
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sped up a few tests by 30-40%.
Results for a 10000 row csv wtih 80 columns