Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Handle numpy deprecation warnings #5615

Merged
merged 4 commits into from Jul 27, 2022

Conversation

NathanFarmer
Copy link
Contributor

Changes proposed in this pull request:

  • Remove usage of np.float in favor of float or np.float64 or correct type
  • Always leverage helper method numpy_quantile for version-specific interpolation parameter

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 19f9132
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/62e14a344dc3fe0009c14c84
😎 Deploy Preview https://deploy-preview-5615--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jul 27, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@NathanFarmer NathanFarmer enabled auto-merge (squash) July 27, 2022 13:17
@NathanFarmer NathanFarmer merged commit 09b4963 into develop Jul 27, 2022
@NathanFarmer NathanFarmer deleted the maintenance/np-float-deprecated-warning branch July 27, 2022 15:43
Shinnnyshinshin pushed a commit that referenced this pull request Jul 29, 2022
* develop: (32 commits)
  [MAINTENANCE] Update stale.yml (#5602)
  [BUGFIX] Patch flaky E2E GX Cloud tests (#5629)
  [MAINTENANCE] CloudDataContext add_datasource test (#5626)
  Fix a typo in batch_request_parameters variable (#5612)
  [RELEASE] 0.15.16 (#5622)
  [BUGFIX] Patch issue with `get_validator` on Cloud-backed `DataContext` (#5619)
  [MAINTENANCE] DataContext in cloud mode test add_datasource (#5625)
  [BUGFIX] Update test due to change in postgres stdev calculation method (#5624)
  [FEATURE] Ensure that `id` propogates from `RuleBasedProfilerConfig` to `RuleBasedProfiler` (#5617)
  [MAINTENANCE] Fix tests in tests/integration/profiling/rule_based_profiler/ and tests/render/renderer/ (#5611)
  Making the dependency on dev-lite clearer (#5514)
  [FEATURE] Implement the exact metric range estimate for NumericMetricRangeMultiBatchParameterBuilder (#5620)
  [MAINTENANCE] remove approximate comparisons -- they will be replaced by estimator alternatives (#5618)
  [FEATURE] DataConnector Query enabled for `SimpleSqlDatasource` (#5610)
  Added numeric column percent diff inclusive bounds expectations (#5586)
  [MAINTENANCE] Handle `numpy` deprecation warnings (#5615)
  [MAINTENANCE] Added Algolia Scripts (#5544)
  [FEATURE] Implement "is_close()" for making equality comparisons "reasonably close" for each ExecutionEngine subclass (#5597)
  [BUGFIX] Support `ExpectationSuite` CRUD at `BaseDataContext` level (#5604)
  [MAINTENANCE] Increase expectation kwarg line stroke width (#5608)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants