[FEATURE] Ensure that id propogates from RuleBasedProfilerConfig to RuleBasedProfiler
#5617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…_expectations into feature/great-1076/great-1083/integrate-id-into-rbp
👇 Click on the image for a new way to code review
Legend |
…_expectations into feature/great-1076/great-1083/integrate-id-into-rbp
anthonyburdi
approved these changes
Jul 27, 2022
anthonyburdi
approved these changes
Jul 27, 2022
anthonyburdi
deleted the
feature/great-1076/great-1083/integrate-id-into-rbp
branch
|
Merged with failing tests that are being fixed in a separate PR. |
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jul 29, 2022
…atch-identifiers * develop: [RELEASE] 0.15.16 (#5622) [BUGFIX] Patch issue with `get_validator` on Cloud-backed `DataContext` (#5619) [MAINTENANCE] DataContext in cloud mode test add_datasource (#5625) [BUGFIX] Update test due to change in postgres stdev calculation method (#5624) [FEATURE] Ensure that `id` propogates from `RuleBasedProfilerConfig` to `RuleBasedProfiler` (#5617)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jul 29, 2022
* develop: (32 commits) [MAINTENANCE] Update stale.yml (#5602) [BUGFIX] Patch flaky E2E GX Cloud tests (#5629) [MAINTENANCE] CloudDataContext add_datasource test (#5626) Fix a typo in batch_request_parameters variable (#5612) [RELEASE] 0.15.16 (#5622) [BUGFIX] Patch issue with `get_validator` on Cloud-backed `DataContext` (#5619) [MAINTENANCE] DataContext in cloud mode test add_datasource (#5625) [BUGFIX] Update test due to change in postgres stdev calculation method (#5624) [FEATURE] Ensure that `id` propogates from `RuleBasedProfilerConfig` to `RuleBasedProfiler` (#5617) [MAINTENANCE] Fix tests in tests/integration/profiling/rule_based_profiler/ and tests/render/renderer/ (#5611) Making the dependency on dev-lite clearer (#5514) [FEATURE] Implement the exact metric range estimate for NumericMetricRangeMultiBatchParameterBuilder (#5620) [MAINTENANCE] remove approximate comparisons -- they will be replaced by estimator alternatives (#5618) [FEATURE] DataConnector Query enabled for `SimpleSqlDatasource` (#5610) Added numeric column percent diff inclusive bounds expectations (#5586) [MAINTENANCE] Handle `numpy` deprecation warnings (#5615) [MAINTENANCE] Added Algolia Scripts (#5544) [FEATURE] Implement "is_close()" for making equality comparisons "reasonably close" for each ExecutionEngine subclass (#5597) [BUGFIX] Support `ExpectationSuite` CRUD at `BaseDataContext` level (#5604) [MAINTENANCE] Increase expectation kwarg line stroke width (#5608) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.