-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix docs_integration pipeline #5734
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
Causing ValueError: Cannot run multiple SparkContexts at once See https://stackoverflow.com/a/47731444
great_expectations.exceptions.exceptions.DataContextError: expectation_suite test_suite_2 not found
Also, "the truth value of a DataFrame is ambiguous" so don't just assert the dataframe that comes back from validator.head(..)
@@ -4,6 +4,7 @@ | |||
--requirement requirements-dev-sqlalchemy.txt | |||
|
|||
--requirement requirements-dev-arrow.txt | |||
--requirement requirements-dev-azure.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be added to these lists?
https://github.com/great-expectations/great_expectations/blob/develop/great_expectations/core/usage_statistics/package_dependencies.py#L67-L151
Or are all its contents already included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…herstinsky/row_condition_json_serialization_datetime_rule_quantiles_column_partion_and_parameter_builder_datetime_handling-2022_08_13-211' into feature/GREAT-906/updated-data-assistant-notebooks-onboarding * pre_pr-prototype/maintenance/GREAT-761/GREAT-ABCD/alexsherstinsky/row_condition_json_serialization_datetime_rule_quantiles_column_partion_and_parameter_builder_datetime_handling-2022_08_13-211: (24 commits) fix regex parameter builder and its test datetime handling for kde estimation datetime handling for bootstrap estimation datetime handling [FEATURE] Enable passing "exact_estimation" boolean at `DataAssistant.run()` level (default value is True) (#5744) clean up clean up [MAINTENANCE] opt-out type-checking (#5713) Update DataAssistantRunner API to accept estimation type argument. Also, sort all domain arguments according to their class signatures. Add plist to build docker test image daily. (#5754) [BUGFIX] Patch flaky E2E Cloud test with randomized suite names (#5752) [MAINTENANCE] invoke docker (#5703) [MAINTENANCE] Clean up type hints around class constructors (#5738) [MAINTENANCE]profile_numeric_columns_diff_expectation (#5741) [MAINTENANCE] Store Refactor - cloud store return types & http-errors (#5730) [MAINTENANCE] Rename GX Cloud "suite_validation_result" resource to "validation_result" (#5749) [BUGFIX] Fix docs_integration pipeline (#5734) cleanup dir update for data_assistant_result makefun version pinning ...
Changes proposed in this pull request: