[DOCS] DOC-366 updates to docs in support of branding updates #5766
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
the
devrel
👇 Click on the image for a new way to code review
Legend |
| @@ -70,13 +70,13 @@ If you are interested in using and accessing data with an Execution Engine that | |||
|
|
|||
| - `name` | |||
| - `caching` | |||
| - `batch_spec_defaults` (is this needed?) | |||
| - `batch_spec_defaults` | |||
There was a problem hiding this comment.
Just checking - should these changes be in this PR?
There was a problem hiding this comment.
The original Jira ticket included a couple more pages that contained the reference we were removing. Those pages were out dated and could be removed entirely (This was obviated by another PR). Along with the instruction to remove those pages, there was a note that execution_engine.md contained content derived from those pages, and that while it did not contain the reference we were removing there were some notes (these ones, specifically) which should be removed. I went ahead and did that as part of "cleanup" for the removing of those other pages, and felt it fell under the mandate of this PR -- it just isn't as apparent now since those removed files ended up being removed by another PR before this one was approved.
There was a problem hiding this comment.
tl;dr yes, these changes were intended for this PR.
Rachel-Reverie
deleted the
DOCS/DOC-366/doc_updates_to_support_branding
branch
…ndex_list * f/dx-21/pandas-adding-pk: [DOCS] DOC-366 updates to docs in support of branding updates (#5766) [RELEASE] 0.15.32 (#6338) [DOCS] DOC-308 update CLI command in docs when working with RBPs instead of Data Assistants (#6222) [DOCS] add `pypi` release badge (#6324) cleaned up tests [BUGFIX] MapMetrics now return `partial_unexpected` values for `SUMMARY` format (#6334) better typing Update test_map_metric.py small clean up clean up expectation intermediate push pushing before refactoring and polishing
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!