Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Clean up xfails in preparation for 0.15.20 release #5835

Merged
merged 1 commit into from Aug 25, 2022
Merged

[MAINTENANCE] Clean up xfails in preparation for 0.15.20 release #5835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions tests/data_context/cloud_data_context/test_profiler_crud.py
View file
Open in desktop
Expand Up @@ -203,11 +203,6 @@ def test_profiler_save_with_new_profiler_retrieves_obj_with_id_from_store(
assert return_profiler.ge_cloud_id == profiler_id


@pytest.mark.xfail(
reason="GX Cloud E2E tests are currently failing due to a schema issue with DataContextVariables; xfailing for purposes of the 0.15.20 release",
run=True,
strict=True,
)
@pytest.mark.e2e
@pytest.mark.cloud
@mock.patch("great_expectations.data_context.DataContext._save_project_config")
Expand Down
5 changes: 2 additions & 3 deletions tests/data_context/test_base_data_context.py
View file
Open in desktop
@@ -1,6 +1,5 @@
import os
import random
import string
from typing import Callable, List, Tuple
from unittest import mock

Expand Down Expand Up @@ -252,7 +251,7 @@ def _closure(context: DataContext) -> Tuple[Validator, str]:


@pytest.mark.xfail(
reason="GX Cloud E2E tests are currently failing due to a schema issue with DataContextVariables; xfailing for purposes of the 0.15.20 release",
reason="GX Cloud E2E tests are currently failing due to an id issue with ExpectationSuites; xfailing for purposes of the 0.15.20 release",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate issue I'll need to look into

run=True,
strict=True,
)
Expand Down Expand Up @@ -286,7 +285,7 @@ def test_get_validator_with_cloud_enabled_context_saves_expectation_suite_to_clo


@pytest.mark.xfail(
reason="GX Cloud E2E tests are currently failing due to a schema issue with DataContextVariables; xfailing for purposes of the 0.15.20 release",
reason="GX Cloud E2E tests are currently failing due to an id issue with ExpectationSuites; xfailing for purposes of the 0.15.20 release",
run=True,
strict=True,
)
Expand Down
10 changes: 0 additions & 10 deletions tests/data_context/test_data_context_variables.py
View file
Open in desktop
Expand Up @@ -570,11 +570,6 @@ def test_file_data_context_variables_e2e(
assert config_saved_to_disk.plugins_directory == f"${env_var_name}"


@pytest.mark.xfail(
reason="GX Cloud E2E tests are currently failing due to a schema issue with DataContextVariables; xfailing for purposes of the 0.15.20 release",
run=True,
strict=True,
)
@pytest.mark.e2e
@pytest.mark.cloud
def test_cloud_data_context_variables_successfully_hits_cloud_endpoint(
Expand All @@ -593,11 +588,6 @@ def test_cloud_data_context_variables_successfully_hits_cloud_endpoint(
assert success is True


@pytest.mark.xfail(
reason="GX Cloud E2E tests are currently failing due to a schema issue with DataContextVariables; xfailing for purposes of the 0.15.20 release",
run=True,
strict=True,
)
@pytest.mark.e2e
@pytest.mark.cloud
@mock.patch("great_expectations.data_context.DataContext._save_project_config")
Expand Down