Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] many small bugfixes #5881

Merged
merged 28 commits into from
Aug 31, 2022
Merged

[BUGFIX] many small bugfixes #5881

merged 28 commits into from
Aug 31, 2022

Conversation

kenwade4
Copy link
Contributor

@kenwade4 kenwade4 commented Aug 30, 2022

DON'T forget to undo the JSON file rename before merging

Changes proposed in this pull request:

  • Add pyogrio as a requirement for expect_column_values_to_be_polygon_area_between.py
  • Use correct imported dialect in pytest_generate_tests func of test_expectations_cfe.py
  • Update pytest_generate_tests func in test_expectation.py to not die if get_asset call fails
  • Add expect_column_values_to_be_valid_arn to skip list in build_gallery.py
  • Use Python 3.8 in expectation_gallery pipeline
  • Before piping to tee with build_gallery.py, redirect error to stdout too
  • Add support for match_like Expectations to redshift/snowflake/bigquery
  • Add redshift/snowflake to suppress list on column_mean Expectation
  • Update check_json_test_result func to make sure result['result']['unexpected_list'] isn't empty
  • Add redshift schemas to some values_to_be_in_set Expectation tests
  • Update get_dialect_regex_expression func to check for redshift another way
  • Supppress mysql/bigquery tests on contrib expect_column_values_to_be_valid_scientific_notation
  • Add a step to expectation_gallery pipeline that shows implemented engines
  • Update run_diagnostics to log an error message if no _expectation_config is available
  • Update _get_expectation_configuration_from_examples to fallback to trying any test input if None are success:True
  • Update _get_execution_engine_diagnostics to not say all engines are implemented when metric_diagnostics_list is empty
  • Change test title prefix from positive to negative for contrib exp not_contain_special_characters
  • Update output in test_expectation_self_check
  • Change how the coverage_score is calculated
  • Add a prefix of Core/Contrib to exp_type in get_expectation_file_info_dict

@github-actions github-actions bot added the devrel This item is being addressed by the Developer Relations Team label Aug 30, 2022
@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit e91ad56
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/630f5484ac187500084cf102
😎 Deploy Preview https://deploy-preview-5881--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Aug 30, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@kenwade4 kenwade4 changed the title [BUGFIX] small bugfixes [BUGFIX] many small bugfixes Aug 31, 2022
Copy link
Contributor

@AFineDayFor AFineDayFor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♀️ merci

logger.debug(
f"Expectation type {sorted(exp_type_set)[0]} for {name} in {file_path}"
f"Expectation type {_prefix}{sorted(exp_type_set)[0]} for {name} in {file_path}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kenwade4 kenwade4 enabled auto-merge (squash) August 31, 2022 12:34
@kenwade4 kenwade4 merged commit 40a8659 into develop Aug 31, 2022
@kenwade4 kenwade4 deleted the misc/small-bugfixes branch August 31, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devrel This item is being addressed by the Developer Relations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants