Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Run spark and onboarding data assistant test in their own jobs. #5951

Merged
merged 5 commits into from
Sep 7, 2022
Merged

[MAINTENANCE] Run spark and onboarding data assistant test in their own jobs. #5951

merged 5 commits into from
Sep 7, 2022

Conversation

billdirks
Copy link
Contributor

@billdirks billdirks commented Sep 7, 2022 •
edited
Loading

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Sep 7, 2022 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit ff32389
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63190c8db772340009b2afcc
😎 Deploy Preview https://deploy-preview-5951--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Sep 7, 2022 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@billdirks billdirks force-pushed the m/GREAT-1047/break-out-spark-tests branch from b4cdb3e to 7154098 Compare September 7, 2022 18:01
@billdirks billdirks changed the title [MAINTENANCE] Make spark run in it's own azure job. [MAINTENANCE] Make spark and onboarding data assistant run in their own azure jobs. Sep 7, 2022
@billdirks billdirks changed the title [MAINTENANCE] Make spark and onboarding data assistant run in their own azure jobs. [MAINTENANCE] Run spark and onboarding data assistant test in their own jobs. Sep 7, 2022
anthonyburdi
anthonyburdi approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One tiny nit

azure-pipelines.yml Outdated Show resolved Hide resolved
@billdirks billdirks enabled auto-merge (squash) September 7, 2022 20:45
@billdirks billdirks mentioned this pull request Sep 7, 2022
Closed
6 tasks
@billdirks billdirks merged commit 2c28bfd into develop Sep 7, 2022
@billdirks billdirks deleted the m/GREAT-1047/break-out-spark-tests branch September 7, 2022 21:38
Shinnnyshinshin pushed a commit that referenced this pull request Sep 7, 2022
Merge branch 'm/GREAT-465/GREAT-1226/GREAT-1227/configured-sql-multi-…
22566bf 
…batch-notebook' of https://github.com/great-expectations/great_expectations into m/GREAT-465/GREAT-1226/GREAT-1227/configured-sql-multi-batch-notebook

* 'm/GREAT-465/GREAT-1226/GREAT-1227/configured-sql-multi-batch-notebook' of https://github.com/great-expectations/great_expectations:
  [MAINTENANCE] More unit tests for `Stores`  (#5953)
  [MAINTENANCE] Unit tests for `ValidationGraph` and related classes (#5954)
  [MAINTENANCE] Run spark and onboarding data assistant test in their own jobs. (#5951)
Shinnnyshinshin pushed a commit that referenced this pull request Sep 8, 2022
Merge branch 'develop' into feature/GREAT-953/migration-part2-refacto…
181e300 
…r-usage-stats-opt

* develop: (62 commits)
  [MAINTENANCE] Bump `Marshmallow` upper bound to work with Airflow operator (#5952)
  [MAINTENANCE] Add x-fails to flaky Cloud tests for purposes of 0.15.22 (#5964)
  [BUGFIX] Prevent "division by zero" errors in Rule-Based Profiler calculations when Batch has zero rows (#5960)
  [FEATURE] Improve slack error condition (#5818)
  [MAINTENANCE] More unit tests for `Stores`  (#5953)
  [MAINTENANCE] Unit tests for `ValidationGraph` and related classes (#5954)
  [MAINTENANCE] Run spark and onboarding data assistant test in their own jobs. (#5951)
  [BUGFIX] prefix and suffix asset names are only relevant for InferredSqlAlchemyDataConnector (#5950)
  Add a dev-tools requirements option (#5944)
  [BUGFIX] Data Assistant plotting with zero expectations produced (#5934)
  [MAINTENANCE] Unit tests for `ConfigurationStore` (#5948)
  [BUGFIX] Don't include abstract Expectation classes in _retrieve_expectations_from_module (#5947)
  [BUGFIX] Making an all-NULL column handling in RuleBasedProfiler more robust (#5937)
  [MAINTENANCE] Run comprehensive tests in a random order (#5942)
  [MAINTENANCE] Update to OnboardingDataAssistant Notebook - Sql (#5939)
  [MAINTENANCE] Add missing import for ConfigurationIdentifier (#5943)
  [MAINTENANCE] Mark tests within `tests/rule_based_profiler` (#5930)
  [MAINTENANCE] Move `Store` test utils from source code to tests (#5932)
  [FEATURE] DataAssistants Example Notebook - Spark (#5919)
  [MAINTENANCE] Reset globals modified in tests (#5936)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyburdi anthonyburdi anthonyburdi approved these changes

Assignees
No one assigned
Labels
core-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billdirks @anthonyburdi