Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Parameterize usage stats endpoint in test dockerfile. #6169

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

billdirks
Copy link
Contributor

@billdirks billdirks commented Oct 18, 2022

Our azure test pipelines should be hitting our qa usage statistics endpoint. This PR parameterizes the usage stats endpoint in our Dockerfile. In the build step for our test image, we set the url to our qa endpoint.

I manually ran this pipeline and I see this new variable being set in the build step:
docker buildx build -f docker/Dockerfile.tests --tag greatexpectations/test:3.9_develop_1666134761_16296 --target test --build-arg PYTHON_VERSION=3.9 --build-arg GE_USAGE_STATISTICS_URL="https://qa.stats.greatexpectations.io/great_expectations/v1/usage_statistics" --build-arg SOURCE=github --build-arg BRANCH=develop .

I also built this image locally and see this get set in my data context:

>>> import great_expectations
>>> great_expectations.get_context()
{
  "anonymous_usage_statistics": {
    "data_context_id": "bfd81bb6-71d1-46b8-a24a-029cc4049cec",
    "usage_statistics_url": "https://qa.stats.greatexpectations.io/great_expectations/v1/usage_statistics",
    "explicit_id": true,
    "explicit_url": true,
    "enabled": true
  },
  ...
}

I've manually run all the failing tests from https://superconductive.atlassian.net/browse/GREAT-1304 in my docker image and they succeed.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for niobium-lead-7998 failed.

Name Link
🔨 Latest commit 0a72a4c
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/634f4214aaf9f20008e4b161

@ghost
Copy link

ghost commented Oct 18, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@billdirks billdirks merged commit e82e725 into develop Oct 19, 2022
@billdirks billdirks deleted the b/GREAT-1304/usage_stats_endpoint branch October 19, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants