Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Update default GE_USAGE_STATISTICS_URL in test docker image. #6192

Merged
merged 3 commits into from
Oct 21, 2022

Conversation

billdirks
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 21, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 8b65e79
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63532893a01b200009f73589
😎 Deploy Preview https://deploy-preview-6192--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Oct 21, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@@ -20,7 +20,7 @@ RUN git clone --filter=tree:0 --branch ${BRANCH} https://github.com/great-expect
WORKDIR /great_expectations

FROM build_${SOURCE} AS dev
ARG GE_USAGE_STATISTICS_URL=""
ARG GE_USAGE_STATISTICS_URL="https://dev.stats.greatexpectations.io/great_expectations/v1/usage_statistics"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@billdirks billdirks enabled auto-merge (squash) October 21, 2022 23:17
@billdirks billdirks merged commit cbf8261 into develop Oct 21, 2022
@billdirks billdirks deleted the docker-usage-stats-url branch October 21, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants