Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Patch issue with empty config variables file raising TypeError #6216

Merged
merged 3 commits into from
Oct 26, 2022
Merged

[BUGFIX] Patch issue with empty config variables file raising TypeError #6216

merged 3 commits into from
Oct 26, 2022

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Oct 26, 2022

Changes proposed in this pull request:

  • Ensure that we aren't trying to convert None to dict

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit c3f0c3e
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6359b79a8279240008147e2c
😎 Deploy Preview https://deploy-preview-6216--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Oct 26, 2022

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@cdkini cdkini enabled auto-merge (squash) October 26, 2022 19:56
@cdkini cdkini self-assigned this Oct 26, 2022
@cdkini cdkini merged commit 264743f into develop Oct 26, 2022
@cdkini cdkini deleted the b/_/patch_issue_with_empty_config_variables_file branch October 26, 2022 23:53
Shinnnyshinshin pushed a commit that referenced this pull request Oct 27, 2022
Merge branch 'develop' into m/DX-20/adding-test-for-expect-column-val…
031e172 
…ue-z-scores-to-be-less-than

* develop:
  [BUGFIX] Patch issue with empty config variables file raising `TypeError` (#6216)
  [MAINTENANCE] Execution Engine linting & partial typing (#6210)
  [FEATURE]/ Added pairwise expectation 'expect_column_pair_values_to_be_in_set' (#6097)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kilo59 Kilo59 Kilo59 approved these changes

@NathanFarmer NathanFarmer NathanFarmer approved these changes

Assignees

@cdkini cdkini

Labels
core-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cdkini @Kilo59 @NathanFarmer