-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] GCP Integration Pipeline fix #6259
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
# The pip freeze output could be helpful to reproduce performance test results. | ||
- publish: pip-freeze.txt | ||
artifact: PipFreeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipfreeze
has not been used to reproduce test results, and is now giving errors in our pipeline.
ApplicationInsightsTelemetrySender correlated 2 events with X-TFS-Session 7df3e132-aada-4a43-b781-0a06fe1923db
##[error]Artifact PipFreeze already exists for build 119157.
Finishing: PublishPipelineArtifact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor change request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for this fix.
Overview
Renaming of
test_expectations_cfe
andtest_expectations
tov2
andv3
(follow up to [MAINTENANCE] Rename cfe to v3_api #6190)Adjusting V3 Expectations for
expect_column_values_to_be_between_tz_informed
What was the issue?
bigquery
Adjusting V2 Expectations for
expect_column_values_to_match_like_pattern
andexpect_column_values_to_not_match_like_pattern
.What was the issue?
bigquery
results in aNotImplementedError
bigquery
Definition of Done