-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] partial cli
+ usage_stats
typing
#6335
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
@@ -48,7 +48,7 @@ def store_list(ctx: click.Context): | |||
) | |||
except Exception as e: | |||
toolkit.exit_with_failure_message_and_stats( | |||
context=context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type-checker caught a real bug/misuse here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kilo59 I reviewed 12 out of 15 files and noted a few questions; once they are answered, I will finish the entire review. Thanks for doing this!
@Kilo59 I am provisionally approving that you fix the failing tests (obviously) and consider my follow-up comment (otherwise, good stuff!). Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending fixing tests and considering the follow up suggesting regarding the use of the Optional
type). Thank you!
SQLA Engine not gx ExecutionEngine
* develop: (31 commits) [BUGFIX] Add sqrt on connect to sqlite database. (#6635) [FEATURE] Docstring linter for public api (#6638) [DOCS] fixing wrong line reference on docs (#6599) [MAINTENANCE] CI - install from `requirements-types.txt` (#6639) [MAINTENANCE] Unexpected Counts table in DataDocs able to show counts for sampled values (#6634) [BUGFIX] Do not round output of proportion computing metrics (#6619) [DOCS] - add anonymous_usage_statistics configutation in documentation (#6626) [FEATURE] Atomic rendering of meta notes (#6627) [MAINTENANCE] Fix develop static type-check stage (#6628) [FEATURE] Accept a `pathlib.Path` `context_root_dir` (#6613) [FEATURE] F/great 1400/sql datasource (#6623) [MAINTENANCE] install `pydantic` in develop pipeline (#6624) [MAINTENANCE] Add `row_condition` logic to `RendererConfiguration` and remove from atomic renderer implementations (#6616) [MAINTENANCE] create cache as part of `--ci` type-checking step (#6621) [FEATURE] Add zep datasource data assistant e2e tests. (#6612) [BUGFIX] Simplify metric results processing and improve detection of Decimal types in columns (#6610) [BUGFIX] Stop overwriting query with static string in RuntimeBatchRequests for SQL (#6614) [MAINTENANCE] update pip installs in pipelines (#6609) [FEATURE] Atomic rendering of Evaluation Parameters (#6232) [MAINTENANCE] partial `cli` + `usage_stats` typing (#6335) ...
Changes proposed in this pull request:
cli
package with flake8unexpected keyword argument
bug incli.store.store_list
- https://github.com/great-expectations/great_expectations/pull/6335/files#r1018392354