[MAINTENANCE] partial cli + usage_stats typing
#6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
Kilo59
commented
Nov 9, 2022
| @@ -48,7 +48,7 @@ def store_list(ctx: click.Context): | |||
| ) | |||
| except Exception as e: | |||
| toolkit.exit_with_failure_message_and_stats( | |||
| context=context, | |||
There was a problem hiding this comment.
type-checker caught a real bug/misuse here
alexsherstinsky
suggested changes
Nov 10, 2022
There was a problem hiding this comment.
@Kilo59 I reviewed 12 out of 15 files and noted a few questions; once they are answered, I will finish the entire review. Thanks for doing this!
|
@Kilo59 I am provisionally approving that you fix the failing tests (obviously) and consider my follow-up comment (otherwise, good stuff!). Thanks! |
alexsherstinsky
approved these changes
Nov 14, 2022
SQLA Engine not gx ExecutionEngine
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Dec 23, 2022
* develop: (31 commits) [BUGFIX] Add sqrt on connect to sqlite database. (#6635) [FEATURE] Docstring linter for public api (#6638) [DOCS] fixing wrong line reference on docs (#6599) [MAINTENANCE] CI - install from `requirements-types.txt` (#6639) [MAINTENANCE] Unexpected Counts table in DataDocs able to show counts for sampled values (#6634) [BUGFIX] Do not round output of proportion computing metrics (#6619) [DOCS] - add anonymous_usage_statistics configutation in documentation (#6626) [FEATURE] Atomic rendering of meta notes (#6627) [MAINTENANCE] Fix develop static type-check stage (#6628) [FEATURE] Accept a `pathlib.Path` `context_root_dir` (#6613) [FEATURE] F/great 1400/sql datasource (#6623) [MAINTENANCE] install `pydantic` in develop pipeline (#6624) [MAINTENANCE] Add `row_condition` logic to `RendererConfiguration` and remove from atomic renderer implementations (#6616) [MAINTENANCE] create cache as part of `--ci` type-checking step (#6621) [FEATURE] Add zep datasource data assistant e2e tests. (#6612) [BUGFIX] Simplify metric results processing and improve detection of Decimal types in columns (#6610) [BUGFIX] Stop overwriting query with static string in RuntimeBatchRequests for SQL (#6614) [MAINTENANCE] update pip installs in pipelines (#6609) [FEATURE] Atomic rendering of Evaluation Parameters (#6232) [MAINTENANCE] partial `cli` + `usage_stats` typing (#6335) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
clipackage with flake8unexpected keyword argumentbug incli.store.store_list- https://github.com/great-expectations/great_expectations/pull/6335/files#r1018392354