[BUGFIX] Contrib Expectation tracebacks #6471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
devrel
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -33,7 +33,7 @@ def is_valid_mic(mic_code: str, df) -> bool: | |||
| class ColumnValuesToBeValidMic(ColumnMapMetricProvider): | |||
|
|
|||
| url = "https://www.iso20022.org/sites/default/files/ISO10383_MIC/ISO10383_MIC.csv" | |||
| df = pd.read_csv(url) | |||
| df = pd.read_csv(url, encoding="cp1250") | |||
There was a problem hiding this comment.
From discussion : this is the encoding of the specific CSV we are using in the test (was failing with unicode)
There was a problem hiding this comment.
That's the actual encoding of the file at that URL
Shinnnyshinshin
approved these changes
Dec 1, 2022
👇 Click on the image for a new way to code review
Legend |
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Dec 5, 2022
* develop: (63 commits) [FEATURE] Support to include ID/PK in validation result for each row - SQL (#6448) [BUGFIX] Support slack channel name with webhook also (#6481) Query the database for datetime column splitter defaults (#6482) [MAINTENANCE] Move "Domain" to "great_expectations/core" to avoid circular imports; also add MetricConfiguration tests; and other clean up. (#6484) [MAINTENANCE] Reformat core expectation docstrings (#6423) [MAINTENANCE] Staging for build gallery (#6480) [MAINTENANCE] Move zep method from datasource to data asset. (#6477) [MAINTENANCE] Minor cleanup for better code readability (#6478) [MAINTENANCE] Misc updates to PR template (#6479) [CONTRIB] Add uniqueness expectation (#6473) [RELEASE] 0.15.36 (#6476) Add pretty representations for zep pydantic models (#6472) [BUGFIX] Contrib Expectation tracebacks (#6471) [BUGFIX] Add additional error checking to `ExpectationAnonymizer` (#6467) Add docstring for context.sources.add_postgres (#6459) [MAINTENANCE] fixing type hints in metrics utils module (#6469) [MAINTENANCE] Moving tutorials to great-expectations repo (#6464) [BUGFIX] Patch issue with call to `ExpectationAnonymizer` to ensure `DataContext` init events are captured (#6458) [BUGFIX] Support Table and Column Names Case Non-Sensitivity Relationship Between Snowflake, Oracle, DB2, etc. DBMSs (Upper Case) and SQLAlchemy (Lower Case) Representations (#6450) Add sorters to zep postgres datasource. (#6456) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build_galllery pipeline has not successfully run since some contrib Expectations starting throwing tracebacks during the build process. This fixes them.
Changes proposed in this pull request: