Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] Update Data Assistant plot images #6521

Merged
merged 3 commits into from
Dec 8, 2022
Merged

[MAINTENANCE] Update Data Assistant plot images #6521

merged 3 commits into from
Dec 8, 2022

Conversation

NathanFarmer
Copy link
Contributor

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 874b6a0
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/639252cdb18a840008311ad3
😎 Deploy Preview https://deploy-preview-6521--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NathanFarmer NathanFarmer self-assigned this Dec 8, 2022
@ghost
Copy link

ghost commented Dec 8, 2022 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@NathanFarmer NathanFarmer changed the title [MAINTENANCE] Update Data Assistant plot image [MAINTENANCE] Update Data Assistant plot images Dec 8, 2022
@NathanFarmer NathanFarmer enabled auto-merge (squash) December 8, 2022 21:13
anthonyburdi
anthonyburdi approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in the netlify preview!

@NathanFarmer NathanFarmer merged commit 1450250 into develop Dec 8, 2022
@NathanFarmer NathanFarmer deleted the m/replace-data-assistant-plot-image branch December 8, 2022 21:17
@NathanFarmer NathanFarmer requested a review from a team December 8, 2022 21:17
Shinnnyshinshin pushed a commit that referenced this pull request Dec 8, 2022
Merge branch 'b/dx-105/result-format-configuration-bug' of https://gi…
351fbae 
…thub.com/great-expectations/great_expectations into b/dx-105/result-format-configuration-bug

* 'b/dx-105/result-format-configuration-bug' of https://github.com/great-expectations/great_expectations:
  [BUGFIX] Patch broken Cloud E2E test around `Datasource` CRUD (#6520)
  [RELEASE] 0.15.37 (#6522)
  [MAINTENANCE] Update Data Assistant plot images (#6521)
  [MAINTENANCE] Clean up GX Cloud environment variable usage (GREAT-1352) (#6501)
  [DOCS] fix(gh-6512): fix rendering of Batch definition (#6513)
  [FEATURE] Decorators for API docs (part 3) (#6504)
  fixed typo in nav
  DO NOT MERGE UNTIL DEC 8: [MAINTENANCE] Brand changes in docs (#6427)
  [BUGFIX] Validator uses proper arguments to show progress bar at Metrics resolution-level (#6510)
  [MAINTENANCE] Make Generated Integration Tests More Robust Using BatchDefinition and InMemoryDataContext In Validator and ExecutionEngine Instantiation (#6505)
  [MAINTENANCE] Clean up `teams.yml` (#6511)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyburdi anthonyburdi anthonyburdi approved these changes

Assignees

@NathanFarmer NathanFarmer

Labels
core-team platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NathanFarmer @anthonyburdi