[FEATURE] Added new expectation: ExpectYesterdayCountComparedToAvgEquivalentDaysOfWeek… #6622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
anthonyburdi
requested changes
Dec 22, 2022
There was a problem hiding this comment.
Hi @HadasManor! Thank you so much for the contribution of this expectation. It looks great, I just have two small requests for changes in the PR comments and then we can merge.
Comment on lines
207
to
208
| f"" | ||
| f"" |
There was a problem hiding this comment.
Just a nitpick, would you mind removing these two extra f"" lines?
..._experimental/expectations/expect_yesterday_count_compared_to_avg_equivalent_days_of_week.py
Show resolved
Hide resolved
|
|
||
|
|
||
| class ExpectYesterdayCountComparedToAvgEquivalentDaysOfWeek(ColumnExpectation): | ||
| """Expect No missing days in date column""" |
There was a problem hiding this comment.
Would you mind elaborating here in the docstring and/or expectation name to make it more clear? Specifically that it is calculating relative to the specific day of the week (e.g. Tues, Fri, etc...) and that it is looking back at only the last 4 weeks?
…EquivalentDaysOfWeek
…EquivalentDaysOfWeek
…EquivalentDaysOfWeek
…EquivalentDaysOfWeek
…yCountComparedToAvgEquivalentDaysOfWeek
anthonyburdi
approved these changes
Dec 29, 2022
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Dec 29, 2022
* develop: [FEATURE] Added new expectation: ExpectYesterdayCountComparedToAvgEquivalentDaysOfWeek… (#6622) [FEATURE] ZEP - load from shared config (#6655) [MAINTENANCE] Add redshift/snowflake casting for sample data on expect_column_values_to_be_of_type (#6659) [MAINTENANCE] Add separate tests for exact stdev for redshift and snowflake (#6658) [MAINTENANCE] Make only column y data_alt different in col_pair_equal tests (#6661) [MAINTENANCE] Update evaluate_json_test_v3_api func to use the debug_logger with useful info when exception occurs (#6653) [MAINTENANCE] Use the correct test for positive_test__exact_min_and_max on trino (#6652) [MAINTENANCE] Update generate_expectation_tests func to only log an ERROR message if there is an error (#6651)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Dec 30, 2022
…eat-expectations/great_expectations into f/dx-106/pandas-named-indices * 'f/dx-106/pandas-named-indices' of https://github.com/great-expectations/great_expectations: [FEATURE] Add sqlite datasource (#6657) [DOCS] doc-356 importable prerequisite box with correct theme applied and default entries (#6666) [DOCS] DOC-400 remove an outdated video link (#6667) [FEATURE] Added new expectation: ExpectYesterdayCountComparedToAvgEquivalentDaysOfWeek… (#6622) [FEATURE] ZEP - load from shared config (#6655) [MAINTENANCE] Add redshift/snowflake casting for sample data on expect_column_values_to_be_of_type (#6659) [MAINTENANCE] Add separate tests for exact stdev for redshift and snowflake (#6658) [MAINTENANCE] Make only column y data_alt different in col_pair_equal tests (#6661)
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Dec 30, 2022
…lag-for-returning-query * develop: [MAINTENANCE] Only spark v2 for special test in not_be_in_set (#6669) [BUGFIX] Avoid key collisions between Rule-Based Profiler terminal literals and MetricConfiguration value keys (#6675) [MAINTENANCE] Make only column y data_alt different in col_pair_in_set tests (#6670) [MAINTENANCE] Add redshift/snowflake casting for sample data on expect_column_values_to_be_in_type_list (#6668) [FEATURE] Add sqlite datasource (#6657) [DOCS] doc-356 importable prerequisite box with correct theme applied and default entries (#6666) [DOCS] DOC-400 remove an outdated video link (#6667) [FEATURE] Added new expectation: ExpectYesterdayCountComparedToAvgEquivalentDaysOfWeek… (#6622) [FEATURE] ZEP - load from shared config (#6655) [MAINTENANCE] Add redshift/snowflake casting for sample data on expect_column_values_to_be_of_type (#6659) [MAINTENANCE] Add separate tests for exact stdev for redshift and snowflake (#6658) [MAINTENANCE] Make only column y data_alt different in col_pair_equal tests (#6661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sOfWeek
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], or [CONTRIB]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in GitHub issues or Slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!