[BUGFIX] Add connect args to execution engine schema #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
itaise
changed the title
itaise
changed the title
amitbend
approved these changes
Dec 29, 2022
| @@ -1004,6 +1004,9 @@ class Meta: | |||
| boto3_options = fields.Dict( | |||
| keys=fields.Str(), values=fields.Str(), required=False, allow_none=True | |||
| ) | |||
| connect_args = fields.Dict( | |||
There was a problem hiding this comment.
Would we be able to add connect_args to ExecutionEngineConfig class above as well?
There was a problem hiding this comment.
Otherwise the PR looks great. thanks for catching this @itaise 🙇🏼
There was a problem hiding this comment.
@Shinnnyshinshin thank you! done :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve this issue.
There is an issue that when creating SQLAlchemy execution engine, if the user send "connect_args" in the execution engine config, it is not passed to the "create_engine" method.
This is because this attribute is dropped when creating the ExecutionEngineConfigSchema.
I checked it locally and this PR solve the issue
Changes proposed in this pull request: