-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add GX Cloud hyperlink to slack notification #6740
[FEATURE] Add GX Cloud hyperlink to slack notification #6740
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
…tions into f/CLOUD-1833-add-programmatic-links-to-oss-slack-notification-renderer
…s-slack-notification-renderer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions!
…cation-renderer' of github.com:great-expectations/great_expectations into f/CLOUD-1833-add-programmatic-links-to-oss-slack-notification-renderer
…cation-renderer' of github.com:great-expectations/great_expectations into HEAD
…s-slack-notification-renderer
@cla-bot check |
…cation-renderer' of github.com:great-expectations/great_expectations into HEAD
@cla-bot check |
…s-slack-notification-renderer
…cation-renderer' of github.com:great-expectations/great_expectations into HEAD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a sweet feature!
…s-slack-notification-renderer
…otification-renderer
…otification-renderer
…otification-renderer
…otification-renderer
…otification-renderer
…otification-renderer
…otification-renderer
Changes proposed in this pull request:
gx_cloud_id
is present, a hyperlink will be included in the Slack Notification after avalidation_result
is generated.Definition of Done