Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add GX Cloud hyperlink to slack notification #6740

Merged
merged 40 commits into from Jan 12, 2023
Merged

[FEATURE] Add GX Cloud hyperlink to slack notification #6740

merged 40 commits into from Jan 12, 2023

Conversation

josectobar
Copy link
Member

@josectobar josectobar commented Jan 9, 2023 •
edited

Changes proposed in this pull request:

  • If a gx_cloud_id is present, a hyperlink will be included in the Slack Notification after a validation_result is generated.
    image

Definition of Done

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 4f9cf24
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63bfa2b4f89d920008111f6c
😎 Deploy Preview https://deploy-preview-6740--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jan 9, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

Merge branch 'develop' of github.com:great-expectations/great_expecta…
33aa903 
…tions into f/CLOUD-1833-add-programmatic-links-to-oss-slack-notification-renderer
@josectobar josectobar marked this pull request as ready for review January 9, 2023 20:18
NathanFarmer
NathanFarmer requested changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions!

great_expectations/checkpoint/actions.py Outdated Show resolved Hide resolved
great_expectations/checkpoint/actions.py Outdated Show resolved Hide resolved
great_expectations/render/renderer/slack_renderer.py Outdated Show resolved Hide resolved
Jose Tobar added 4 commits January 10, 2023 15:30
removed base_url param
b01a47a
Merge branch 'f/CLOUD-1833-add-programmatic-links-to-oss-slack-notifi…
bf549f8 
…cation-renderer' of github.com:great-expectations/great_expectations into f/CLOUD-1833-add-programmatic-links-to-oss-slack-notification-renderer
Adjust naming and references
2be2b60
Update test
dbeb9f5
@kenwade4 kenwade4 removed their assignment Jan 11, 2023
NathanFarmer and others added 3 commits January 11, 2023 16:29
@NathanFarmer
Add OSS support
6696a70
@NathanFarmer
Merge branch 'f/CLOUD-1833-add-programmatic-links-to-oss-slack-notifi…
7ee708f 
…cation-renderer' of github.com:great-expectations/great_expectations into HEAD
@NathanFarmer
Merge branch 'develop' into f/CLOUD-1833-add-programmatic-links-to-os…
0e0d0a7 
…s-slack-notification-renderer
@NathanFarmer
Copy link
Contributor

@cla-bot check

@NathanFarmer
Not and f string anymore
9ace1f6
@NathanFarmer
Merge branch 'f/CLOUD-1833-add-programmatic-links-to-oss-slack-notifi…
85ff5f2 
…cation-renderer' of github.com:great-expectations/great_expectations into HEAD
@josectobar
Copy link
Member Author

@cla-bot check

@NathanFarmer NathanFarmer self-requested a review January 11, 2023 22:17
NathanFarmer
NathanFarmer approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@NathanFarmer NathanFarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sweet feature!

@josectobar josectobar enabled auto-merge (squash) January 11, 2023 22:18
github-actions bot and others added 9 commits January 11, 2023 23:29
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
127a262 
…otification-renderer
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
2a8bb2a 
…otification-renderer
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
0b1459f 
…otification-renderer
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
465b23f 
…otification-renderer
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
738b719 
…otification-renderer
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
7947a17 
…otification-renderer
@github-actions
Merge develop into f/CLOUD-1833-add-programmatic-links-to-oss-slack-n…
4a9453b 
…otification-renderer
@NathanFarmer
Broken import
2444ce4
@NathanFarmer
Not an f-string
4f9cf24
@josectobar josectobar merged commit e27683f into develop Jan 12, 2023
@josectobar josectobar deleted the f/CLOUD-1833-add-programmatic-links-to-oss-slack-notification-renderer branch January 12, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFarmer NathanFarmer NathanFarmer approved these changes

Assignees
No one assigned
Labels
core-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@josectobar @NathanFarmer @anthonyburdi @kenwade4