Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] ID/PK - Adding semi-colon to SQL Query output #6743

Merged
merged 10 commits into from
Jan 11, 2023
Merged

[MAINTENANCE] ID/PK - Adding semi-colon to SQL Query output #6743

merged 10 commits into from
Jan 11, 2023

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Jan 9, 2023 •
edited

Changes proposed in this pull request:

  • SQL Query output requires a ; at the end to be executable.
  • Updating the Metric output, and tests

Definition of Done

@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 806989e
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63bdfb4809d9170009598ea3
😎 Deploy Preview https://deploy-preview-6743--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Shinnnyshinshin Shinnnyshinshin self-assigned this Jan 9, 2023
@ghost
Copy link

ghost commented Jan 9, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Shinnnyshinshin Shinnnyshinshin marked this pull request as ready for review January 10, 2023 01:07
@Shinnnyshinshin Shinnnyshinshin changed the title [MAINTENANCE] ID/PK - Adding final touch to SQL Query output [MAINTENANCE] ID/PK - Adding semi-colon to SQL Query output Jan 10, 2023
anthonyburdi
anthonyburdi approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice QoL improvement!

@Shinnnyshinshin Shinnnyshinshin enabled auto-merge (squash) January 10, 2023 22:04
@Shinnnyshinshin Shinnnyshinshin merged commit 679525c into develop Jan 11, 2023
@Shinnnyshinshin Shinnnyshinshin deleted the f/dx-21/clean-up-sql-query branch January 11, 2023 00:39
jcampbell pushed a commit that referenced this pull request Jan 11, 2023
@jcampbell
[MAINTENANCE] ID/PK - Adding semi-colon to SQL Query output (#6743)
b66af72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyburdi anthonyburdi anthonyburdi approved these changes

Assignees

@Shinnnyshinshin Shinnnyshinshin

Labels
core-team dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shinnnyshinshin @anthonyburdi