Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Use environment variables for expectation gallery data paths #6805

Conversation

anthonyburdi
Copy link
Member

Changes proposed in this pull request:

  • Use environment variables instead of hardcoding paths

Definition of Done

@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit d91770b
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63c1caf6325e3f0008a59220
😎 Deploy Preview https://deploy-preview-6805--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jan 13, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@anthonyburdi anthonyburdi enabled auto-merge (squash) January 13, 2023 21:11
@anthonyburdi anthonyburdi merged commit 4b32a24 into develop Jan 13, 2023
@anthonyburdi anthonyburdi deleted the m/dx-210/use_environment_variables_for_expectation_gallery_data_paths branch January 13, 2023 22:18
Shinnnyshinshin pushed a commit that referenced this pull request Jan 18, 2023
…ttps://github.com/great-expectations/great_expectations into m/dx-21/dx-157/suppress-warnings-for-result-format

* 'm/dx-21/dx-157/suppress-warnings-for-result-format' of https://github.com/great-expectations/great_expectations: (57 commits)
  [MAINTENANCE] Use shortened_dotted_paths in API docs (#6820)
  [MAINTENANCE] Use Enum classes for all metric name suffixes (#6819)
  [BUGFIX]: expect_day_count_to_be_close_to_equivalent_week_day_mean (#6811)
  [CONTRIB] Improve contrib schwifty expectations (#6812)
  Add docstring for `AbstractDataContext.add_checkpoint` (#6728)
  [BUGFIX] Implemented lowercase function to check what type of file endswith (#6810)
  [DOCS] ExpectationSuite and remove_expectation api docs (#6785)
  [MAINTENANCE] Clean up public api report part 3 (#6803)
  [MAINTENANCE] Fixes for column_values_to_be_between tests (#6809)
  [MAINTENANCE] Improve type hints in ExecutionEngine.resolve_metrics() flow and delete unnecessary checks (#6804)
  [BUGFIX] Fix missing not operator ~ (#6808)
  Suppress 2 kl_divergence datasets for bigquery that took 90 minutes to insert (#6807)
  [MAINTENANCE] Use environment variables for expectation gallery data paths (#6805)
  [MAINTENANCE] Add checkpoint and datadoc integration test for zep pandas datasource. (#6793)
  [DOCS] Link to gh issue #4152 for ruamel.yaml (#6799)
  [MAINTENANCE] Misc docstrings in `AbstractDataContext` (#6801)
  [MAINTENANCE] Shift daily gallery run by 6 hours (#6802)
  [MAINTENANCE] Clean up public api report part 2 (#6792)
  [MAINTENANCE] Clean up public api report part 1 (#6784)
  [MAINTENANCE] Only include relevant diagnostics info in gallery JSON (#6797)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants