Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable name error associated with adding typing and docstrings #6980

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix variable name error associated with adding typing and docstrings #6980

merged 1 commit into from
Jan 28, 2023

Conversation

billdirks
Copy link
Contributor

@billdirks billdirks commented Jan 28, 2023 •
edited

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

@netlify
Copy link

netlify bot commented Jan 28, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 8c17374
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63d46902f4d385000880464a
😎 Deploy Preview https://deploy-preview-6980--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jan 28, 2023

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@billdirks billdirks mentioned this pull request Jan 28, 2023
Closed
@billdirks billdirks enabled auto-merge (squash) January 28, 2023 00:17
alexsherstinsky
alexsherstinsky approved these changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@billdirks billdirks merged commit 5326827 into develop Jan 28, 2023
@billdirks billdirks deleted the d/dx-237/add-some-json-serialization-docstrings-fix branch January 28, 2023 01:15
Shinnnyshinshin pushed a commit that referenced this pull request Jan 28, 2023
Merge branch 'f/dx-244/dx-246/pandas-id-pk-column-pair-map-metric' of h…
8f77a04 
…ttps://github.com/great-expectations/great_expectations into f/dx-244/dx-246/pandas-id-pk-column-pair-map-metric

* 'f/dx-244/dx-246/pandas-id-pk-column-pair-map-metric' of https://github.com/great-expectations/great_expectations:
  Fix variable name error associated with adding typing and docstrings (#6980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsherstinsky alexsherstinsky alexsherstinsky approved these changes

@anthonyburdi anthonyburdi Awaiting requested review from anthonyburdi

Assignees
No one assigned
Labels
core-team platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@billdirks @alexsherstinsky