Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINTENANCE] xfail ZEP async spark tests for release #7038

Merged
merged 6 commits into from Feb 2, 2023
Merged

[MAINTENANCE] xfail ZEP async spark tests for release #7038

merged 6 commits into from Feb 2, 2023

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Feb 2, 2023 •
edited

Changes proposed in this pull request:

  • xfail 2 zep pyspark tests to unblock the release
  • xfails will be remove in a followup PR

@Kilo59 Kilo59 marked this pull request as ready for review February 2, 2023 17:54
@netlify
Copy link

netlify bot commented Feb 2, 2023 •
edited

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit aa39488
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63dc08754e57620008f42376
😎 Deploy Preview https://deploy-preview-7038--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Feb 2, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@Kilo59 Kilo59 changed the title xfail async spark tests [MAINTENANCE] xfail ZEP async spark tests for release Feb 2, 2023
@Kilo59 Kilo59 enabled auto-merge (squash) February 2, 2023 17:59
@Kilo59 Kilo59 requested a review from cdkini February 2, 2023 18:53
@Kilo59 Kilo59 added the zep Zero Entry Pool work label Feb 2, 2023
@Kilo59 Kilo59 merged commit 9577f73 into develop Feb 2, 2023
@Kilo59 Kilo59 deleted the m/great-1584/spark-async-test-fix branch February 2, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFarmer NathanFarmer NathanFarmer approved these changes

@billdirks billdirks Awaiting requested review from billdirks

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky

@cdkini cdkini Awaiting requested review from cdkini

Assignees
No one assigned
Labels
core-team platform zep Zero Entry Pool work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kilo59 @NathanFarmer