-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] ID/PK - Rendering ColumnPair
and MultiColumn
Expectations in DataDocs
#7041
[BUGFIX] ID/PK - Rendering ColumnPair
and MultiColumn
Expectations in DataDocs
#7041
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
@@ -103,6 +103,7 @@ def _prescriptive_renderer( | |||
runtime_configuration: Optional[dict] = None, | |||
**kwargs, | |||
) -> None: | |||
# TODO: Need for prescriptive renderer for Expectation if we want to render in DataDocs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found this Expectation does not actually have any renderers
implemented. Added TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for fixing this. I think the new implementation is great and leverages pandas for the heavy lifting.
What is in this PR?
_convert_unexpected_indices_to_df()
has been refactored to take in domain column list, and generate counts, so there is no need to map back topartial_unexpected_counts
dict.build_count_and_index_table()
has been refactored to use the DF outputted by_convert_unexpected_indices_to_df()
.test_util.py
to test MultiColumnExpectation and ColumnPairExpectation.Definition of Done
Please delete options that are not relevant.