[DOCS] FDS Deployment Pattern - AWS S3 Pandas #7718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
Shinnnyshinshin
commented
Apr 25, 2023
| <PythonTabTest /> | ||
|
|
There was a problem hiding this comment.
These changes are the result of the linter
Shinnnyshinshin
changed the title
…/great-expectations/great_expectations into m/_/deployment-pattern-s3-pandas * 'm/_/deployment-pattern-s3-pandas' of https://github.com/great-expectations/great_expectations: [MAINTENANCE] Update a Fluent Datasource related fixture name to better reflect its capabilities (#7725)
Shinnnyshinshin
commented
Apr 25, 2023
| @@ -1863,7 +1863,7 @@ def main(): | |||
| # any methods or classes you are adding to documentation with the @public_api | |||
| # decorator and any relevant "new" or "deprecated" public api decorators. | |||
| # If the actual is lower than the threshold, please reduce the threshold. | |||
| PUBLIC_API_MISSING_THRESHOLD = 92 # TODO: reduce this number again once this works for the Fluent DS dynamic methods | |||
| PUBLIC_API_MISSING_THRESHOLD = 99 # TODO: reduce this number again once this works for the Fluent DS dynamic methods | |||
There was a problem hiding this comment.
This had to be raised because I refer to more FDS methods in my script
Kilo59
reviewed
Apr 25, 2023
tests/integration/docusaurus/deployment_patterns/aws_cloud_storage_pandas.py
Outdated
Show resolved
Hide resolved
Kilo59
reviewed
Apr 25, 2023
tests/integration/docusaurus/deployment_patterns/aws_cloud_storage_pandas.py
Outdated
Show resolved
Hide resolved
…rage_pandas.py Co-authored-by: Gabriel <gabriel59kg@gmail.com>
…/great-expectations/great_expectations into m/_/deployment-pattern-s3-pandas * 'm/_/deployment-pattern-s3-pandas' of https://github.com/great-expectations/great_expectations: Update tests/integration/test_definitions/s3/integration_tests.py
This reverts commit 002add6.
Kilo59
reviewed
Apr 26, 2023
There was a problem hiding this comment.
Looking at the deploy preview here I think most of these extra imports are unnecessary.
There was a problem hiding this comment.
This was as miss on my part. The section was referring to a different (spark s3 data context) doc. Doc has been updated.
Kilo59
approved these changes
Apr 26, 2023
…/great-expectations/great_expectations into m/_/deployment-pattern-s3-pandas * 'm/_/deployment-pattern-s3-pandas' of https://github.com/great-expectations/great_expectations: [MAINTENANCE] fix get available data assets names for fds (#7723)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
tests/integration/docusaurus/deployment_patterns/aws_cloud_storage_pandas.pythat tests the workflow.test_script_runner.pyDefinition of Done