Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Upper bound pyathena due to breaking API in V3 #7821

Merged
merged 1 commit into from
May 4, 2023

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented May 4, 2023

Changes proposed in this pull request:

  • from pyathena import sqlalchemy_athena no longer works in V3
    • Let's set an upper bound so our current code work
    • Should circle back to see what imports we can use to support both

Definition of Done

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 0271e3a
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/645418ef3dc40f00084aea11

@github-actions github-actions bot added the core label May 4, 2023
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link

ghost commented May 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@cdkini cdkini merged commit 8fc0197 into develop May 4, 2023
@cdkini cdkini deleted the b/_/patch_pyathena branch May 4, 2023 20:53
Shinnnyshinshin added a commit that referenced this pull request May 5, 2023
* develop: (29 commits)
  [DOCS] Update docs for how_to_initialize_a_filesystem_data_context_in_python (#7831)
  [MAINTENANCE] Clean up: Remove duplicated fixture and utilize deeper filtering mechanism for configuration assertions. (#7825)
  [MAINTENANCE] Enable Spark-S3 Integration tests on Azure CI/CD (#7819)
  [MAINTENANCE] FDS - Datasources can rebuild their own asset data_connectors (#7826)
  [DOCS] Prerequisites Cleanup (#7811)
  [BUGFIX] Azure Package Presence/Absence Tests Strengthening (#7818)
  [RELEASE] 0.16.11 (#7824)
  [MAINTENANCE] Fix pin count. (#7823)
  [BUGFIX] Upper bound `pyathena` due to breaking API in V3 (#7821)
  [MAINTENANCE] Fix linting error. (#7820)
  [BUGFIX] Cloud - Fix FDS Asset has no attribute `_data_connector` (#7813)
  [BUGFIX] AWS Docs reference clash (#7817)
  [FEATURE] Enable passing "spark_config" through to "SparkDFExecutionEngine" constructor as arguments to "add_spark*()" Fluent Datasources methods. (#7810)
  [MAINTENANCE] Remove runme fixtures/stages and enable docs-integration to run automatically (#7812)
  [MAINTENANCE] docs-integration re-start (#7735)
  [MAINTENANCE] Lint `tests/checkpoint` & `tests/execution_engine` (#7804)
  [BUGFIX] Repair handling of regular expressions partitioning for cloud file storage environments utilizing prefix directive. (#7798)
  [MAINTENANCE] Dont run runme_script_runner_tests stage on forks (#7807)
  [DOCS] FDS Deployment Pattern - AWS: Spark and S3 (#7775)
  [MAINTENANCE] Update all pytest calls in CI to show reason skipped (#7806)
  ...
Shinnnyshinshin added a commit that referenced this pull request May 8, 2023
* develop: (79 commits)
  [DOCS] Removing datasource centric test_yaml_config doc (#7836)
  [FEATURE] Splitters work with Spark Fluent Datasources (#7832)
  [MAINTENANCE] New PR template (#7710)
  [DOCS] Update how to create a checkpoint with Test YAML config (#7835)
  [DOCS] Updating Checkpoint terms page (#7722)
  [BUGFIX] Adding support for Fluent Batch Requests to context.get_validator (#7808)
  [FEATURE] Plumbing of validation_result_url from cloud response (#7809)
  [MAINTENANCE] Enable S3/Spark Connecting To Your Data tests (#7828)
  [BUGFIX] Handle "persist" directive in "SparkDFExecutionEngine" properly. (#7830)
  [DOCS] Update docs for how_to_initialize_a_filesystem_data_context_in_python (#7831)
  [MAINTENANCE] Clean up: Remove duplicated fixture and utilize deeper filtering mechanism for configuration assertions. (#7825)
  [MAINTENANCE] Enable Spark-S3 Integration tests on Azure CI/CD (#7819)
  [MAINTENANCE] FDS - Datasources can rebuild their own asset data_connectors (#7826)
  [DOCS] Prerequisites Cleanup (#7811)
  [BUGFIX] Azure Package Presence/Absence Tests Strengthening (#7818)
  [RELEASE] 0.16.11 (#7824)
  [MAINTENANCE] Fix pin count. (#7823)
  [BUGFIX] Upper bound `pyathena` due to breaking API in V3 (#7821)
  [MAINTENANCE] Fix linting error. (#7820)
  [BUGFIX] Cloud - Fix FDS Asset has no attribute `_data_connector` (#7813)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants