[BUGFIX] Handle "persist" directive in "SparkDFExecutionEngine" properly. #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…ete_persist_directive_from_sparkdf_execution_engine_instantiation_arguments-2023_05_05-18
alexsherstinsky
deleted the
maintenance/DX-469/DX-480/alexsherstinsky/link/delete_persist_directive_from_sparkdf_execution_engine_instantiation_arguments-2023_05_05-18
branch
Shinnnyshinshin
added a commit
that referenced
this pull request
May 8, 2023
* develop: (79 commits) [DOCS] Removing datasource centric test_yaml_config doc (#7836) [FEATURE] Splitters work with Spark Fluent Datasources (#7832) [MAINTENANCE] New PR template (#7710) [DOCS] Update how to create a checkpoint with Test YAML config (#7835) [DOCS] Updating Checkpoint terms page (#7722) [BUGFIX] Adding support for Fluent Batch Requests to context.get_validator (#7808) [FEATURE] Plumbing of validation_result_url from cloud response (#7809) [MAINTENANCE] Enable S3/Spark Connecting To Your Data tests (#7828) [BUGFIX] Handle "persist" directive in "SparkDFExecutionEngine" properly. (#7830) [DOCS] Update docs for how_to_initialize_a_filesystem_data_context_in_python (#7831) [MAINTENANCE] Clean up: Remove duplicated fixture and utilize deeper filtering mechanism for configuration assertions. (#7825) [MAINTENANCE] Enable Spark-S3 Integration tests on Azure CI/CD (#7819) [MAINTENANCE] FDS - Datasources can rebuild their own asset data_connectors (#7826) [DOCS] Prerequisites Cleanup (#7811) [BUGFIX] Azure Package Presence/Absence Tests Strengthening (#7818) [RELEASE] 0.16.11 (#7824) [MAINTENANCE] Fix pin count. (#7823) [BUGFIX] Upper bound `pyathena` due to breaking API in V3 (#7821) [MAINTENANCE] Fix linting error. (#7820) [BUGFIX] Cloud - Fix FDS Asset has no attribute `_data_connector` (#7813) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
persistconstructor argument toSparkDFExecutionEnginehas been defined, but not utilized. (This was an omission from GX V2.) Now, this directive is used as intended (thedataframe.persist()is called).Remark
persistisTrueby default, processing of largeSparkdataframes is expected to be more efficient.Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], or [CONTRIB]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in GitHub issues or Slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!