[FEATURE] DataProfilerColumnDomainBuilder #7920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
micdavis
force-pushed
the
dp_col_domain_buider
branch
from
1e16141
to
67e17aa
Compare
|
This PR fixes issues with #7770. Had to make a new PR because I don't have write access to @alexjeilert remote. #7770 can be closed out. If there are no questions, comments, or concerns with this @alexsherstinsky please enable auto-merge. |
4 tasks
Shinnnyshinshin
added a commit
that referenced
this pull request
May 18, 2023
* develop: [MAINTENANCE] Update `teams.yml` (#7934) [RELEASE] 0.16.13 (#7933) [MAINTENANCE] Fixing pytest: renderer assertion (#7928) [FEATURE] Add "batch.columns()" convenience method to Fluent DataAsset implementation. (#7926) [FEATURE] DataProfilerColumnDomainBuilder (#7920) [MAINTENANCE] Fixes Glue tests on vanilla pytest (#7925) [DOCS] CLI Clean-up (#7904) [FEATURE]: DataProfilerStructuredDataAssistant Float Rule (#7842) [BUGFIX] Fix remaining FDS config substitution issues (#7917) [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/filesystem/how_to_connect_to_one_or_more_files_using_pandas" (#7922) [DOCS] How to Edit Existing `ExpectationSuite` (#7859) [MAINTENANCE] Add `docs/*.py` to `GXChanged` for linting (#7924) [MAINTENANCE] Use with open file to reduce open files within tests (#7906) [MAINTENANCE] Removing engine-specific tests that assert generic behavior (#7918) [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/data_assets/how_to_organize_batches_in_a_sql_based_data_asset" (#7909)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Updated DataProfilerColumnDomainBuilder class to remove profile_path instance variable.
Updated DataProfilerColumnDomainBuilder's _get_domains() function to take in profile_path, metric, and metric_values as a part of variables
Updated DataProfilerTableColumnList to filter columns from the profile object by checking if the metric of the column is in metric_values
Updated test_data_profiler_column_domain_builder and test_data_profiler_structured_data_assistant to match updated DataProfilerColumnDomainBuilder functionality
My code follows the Great Expectations style guide
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added unit tests where applicable and made sure that new and existing tests are passing.