Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] CLI Clean-up #7904

Merged
merged 36 commits into from
May 18, 2023
Merged

[DOCS] CLI Clean-up #7904

merged 36 commits into from
May 18, 2023

Conversation

donaldheppner
Copy link
Member

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted
  • Appropriate tests and docs have been updated

@netlify
Copy link

netlify bot commented May 16, 2023 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit 80225ad
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6466223a8c549700087f8b98

@github-actions github-actions bot added the core label May 16, 2023
@donaldheppner donaldheppner marked this pull request as draft May 16, 2023 16:25
@ghost
Copy link

ghost commented May 16, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@donaldheppner donaldheppner marked this pull request as ready for review May 16, 2023 18:11
@donaldheppner donaldheppner mentioned this pull request May 16, 2023
Closed
3 tasks
donaldheppner and others added 2 commits May 16, 2023 19:29
@donaldheppner @kwcanuck
Apply suggestions from code review
a636d44 
Co-authored-by: Rob Gray <104205257+kwcanuck@users.noreply.github.com>
@donaldheppner
Merge branch 'develop' into d/DOC-411/cleanup-0516
2f6fb88
@donaldheppner donaldheppner enabled auto-merge (squash) May 16, 2023 23:29
donaldheppner and others added 18 commits May 17, 2023 09:13
@donaldheppner
Merge branch 'develop' into d/DOC-411/cleanup-0516
5d444d6
@github-actions
Merge develop into d/DOC-411/cleanup-0516
3af5fad
@github-actions
Merge develop into d/DOC-411/cleanup-0516
4c206af
@github-actions
Merge develop into d/DOC-411/cleanup-0516
94b64f0
@donaldheppner
grr
4b3961d
@donaldheppner
Merge branch 'd/DOC-411/cleanup-0516' of https://github.com/great-exp…
bbdb54e 
…ectations/great_expectations into d/DOC-411/cleanup-0516
@donaldheppner
Merge branch 'develop' into d/DOC-411/cleanup-0516
a889250
@github-actions
Merge develop into d/DOC-411/cleanup-0516
def63b3
@github-actions
Merge develop into d/DOC-411/cleanup-0516
d510ce7
@donaldheppner
linting
b8878ed
@github-actions
Merge develop into d/DOC-411/cleanup-0516
adf1ce9
@Shinnnyshinshin
final rename
64c5024
@Shinnnyshinshin
Merge branch 'd/DOC-411/cleanup-0516' of https://github.com/great-exp…
394e760 
…ectations/great_expectations into d/DOC-411/cleanup-0516

* 'd/DOC-411/cleanup-0516' of https://github.com/great-expectations/great_expectations:
  [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/data_assets/how_to_organize_batches_in_a_sql_based_data_asset" (#7909)
@github-actions
Merge develop into d/DOC-411/cleanup-0516
d39ae08
@github-actions
Merge develop into d/DOC-411/cleanup-0516
c40973b
@github-actions
Merge develop into d/DOC-411/cleanup-0516
a44a8ea
@donaldheppner
Merge branch 'develop' into d/DOC-411/cleanup-0516
475aabc
@github-actions
Merge develop into d/DOC-411/cleanup-0516
80225ad
@donaldheppner donaldheppner merged commit f43c148 into develop May 18, 2023
@donaldheppner donaldheppner deleted the d/DOC-411/cleanup-0516 branch May 18, 2023 14:06
Shinnnyshinshin added a commit that referenced this pull request May 18, 2023
@Shinnnyshinshin
Merge branch 'develop' into m/dx-445/dx-446/bump-minimum-version-38
8f4b7d6 
* develop:
  [MAINTENANCE] Update `teams.yml` (#7934)
  [RELEASE] 0.16.13 (#7933)
  [MAINTENANCE] Fixing pytest: renderer assertion (#7928)
  [FEATURE] Add "batch.columns()" convenience method to Fluent DataAsset implementation. (#7926)
  [FEATURE] DataProfilerColumnDomainBuilder (#7920)
  [MAINTENANCE] Fixes Glue tests on vanilla pytest (#7925)
  [DOCS] CLI Clean-up (#7904)
  [FEATURE]: DataProfilerStructuredDataAssistant Float Rule (#7842)
  [BUGFIX] Fix remaining FDS config substitution issues (#7917)
  [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/filesystem/how_to_connect_to_one_or_more_files_using_pandas" (#7922)
  [DOCS] How to Edit Existing `ExpectationSuite` (#7859)
  [MAINTENANCE] Add `docs/*.py` to `GXChanged` for linting  (#7924)
  [MAINTENANCE] Use with open file to reduce open files within tests (#7906)
  [MAINTENANCE] Removing engine-specific tests that assert generic behavior (#7918)
  [FEATURE] Implementing Python code snippets under test for "https://docs.greatexpectations.io/docs/guides/connecting_to_your_data/fluent/data_assets/how_to_organize_batches_in_a_sql_based_data_asset" (#7909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwcanuck kwcanuck kwcanuck approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donaldheppner @kwcanuck @Shinnnyshinshin