New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Helpful Message for Expectations that require Metrics that are not available #8906
[MAINTENANCE] Helpful Message for Expectations that require Metrics that are not available #8906
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
I like the extra error message; that seems much more helpful. Is this the only fix needed for #8619, then? Does this mean that for databases with case-insensitive column names, GX users will need to define expectations with case-sensitive column names? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - just wondering about the pythonsqlite.db-journal
file added. Could you clarify why that was added?
] | ||
|
||
|
||
def fake_expectation_config( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good names make things so much easier ❤️ Thank you for refactoring this.
….com/great-expectations/great_expectations into m/zel-164/better-messaging-validator * 'm/zel-164/better-messaging-validator' of https://github.com/great-expectations/great_expectations: [CONTRIB][FEATURE]-add-threshold-parameter (#8891) [DOCS] Create a New Get Support Topic (#8849) [MAINTENANCE] E2E Test - Spark Filesystem with Cloud (#8889) [DOCS] Remove TOC Content Duplication (#8917)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful error message, thanks for this PR!
Currently, if an Expectation is misconfigured (such as referencing a non-existent column name), we get a cryptic error message.
This PR adds a check in
expectation.py
, where we validate dependencies of the current Expectation against available metrics, and outputs a more helpful error message:An error message will look something like this:
invoke lint
(usesblack
+ruff
)