Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Prettier yaml formatting #9562

Merged
merged 9 commits into from Mar 4, 2024
Merged

[MAINTENANCE] Prettier yaml formatting #9562

merged 9 commits into from Mar 4, 2024

Conversation

Kilo59
Copy link
Member

@Kilo59 Kilo59 commented Mar 1, 2024

Use a prettier pre-commit hook for consistent yaml formatting.

https://prettier.io/docs/en/precommit.html#option-2-pre-commithttpsgithubcompre-commitpre-commit

Why

Consistent YAML formatting.
Eliminate formatting and whitespace changes to YAML files.
Makes reviewing changes and debugging easier.

This will be followed up with a .git-blame-ignore-revs entry.

See also...

Vote on " vs ' in our Slack.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit e33ee13
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65e5d5b8472b410008adabc3
😎 Deploy Preview https://deploy-preview-9562.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kilo59 Kilo59 self-assigned this Mar 1, 2024
@Kilo59 Kilo59 marked this pull request as ready for review March 1, 2024 21:08
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so pretty

Comment on lines 29 to 37
args: ['--fix']
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v4.0.0-alpha.8
hooks:
- id: prettier
args: ['--single-quote']
types_or: [yaml]
exclude: tests/data_context/fixtures/bad_yml
# Github Actions Linter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Kilo59 Kilo59 added this pull request to the merge queue Mar 4, 2024
Merged via the queue into develop with commit 179c974 Mar 4, 2024
67 checks passed
@Kilo59 Kilo59 deleted the m/_/yaml_fmt branch March 4, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants