[MAINTENANCE] Make Validation definitions immutable #9606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…_expectations into m/v1-233/immutable_validation_defs
cdkini
commented
Mar 11, 2024
Comment on lines
-237
to
-244
| @public_api | ||
| def save(self) -> None: | ||
| key = self._store.get_key(name=self.name, id=self.id) | ||
|
|
||
| try: | ||
| self._store.update(key=key, value=self) | ||
| except gx_exceptions.StoreBackendError: | ||
| raise ValueError("ValidationConfig must be added to a store before saving.") |
There was a problem hiding this comment.
save() is an update method so we no longer need it (or the store dep)
tyler-hoffman
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation definitions should not be able to be updated. If you want a change, you simply create a new one.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!