[MAINTENANCE] Make Validation definitions immutable

great_expectations/core/validation_config.py

@@ -6,7 +6,7 @@
 from great_expectations._docs_decorators import public_api
 from great_expectations.compatibility.pydantic import (
     BaseModel,
-    PrivateAttr,
+    Field,
     ValidationError,
     validator,
 )
@@ -15,9 +15,6 @@
     ExpectationSuite,
     expectationSuiteSchema,
 )
-from great_expectations.data_context.store.validation_config_store import (
-    ValidationConfigStore,  # noqa: TCH001
-)
 from great_expectations.validator.v1_validator import ResultFormat, Validator
 
 if TYPE_CHECKING:
@@ -87,6 +84,7 @@ class Config:
         arbitrary_types_allowed = (
             True  # Necessary for compatibility with suite's Marshmallow dep
         )
+        validate_assignment = True
         """
         When serialized, the suite and data fields should be encoded as a set of identifiers.
         These will be used as foreign keys to retrieve the actual objects from the appropriate stores.
@@ -120,18 +118,11 @@ class Config:
             BatchConfig: lambda b: _encode_data(b),
         }
 
-    name: str
-    data: BatchConfig  # TODO: Should support a union of Asset | BatchConfig
-    suite: ExpectationSuite
+    name: str = Field(..., allow_mutation=False)
+    data: BatchConfig = Field(..., allow_mutation=False)
+    suite: ExpectationSuite = Field(..., allow_mutation=False)
     id: Union[str, None] = None
 
-    # private attributes that must be set immediately after instantiation
-    _store: ValidationConfigStore = PrivateAttr()
-
-    def __init__(self, **data: Any):
-        super().__init__(**data)
-        self._store = project_manager.get_validation_config_store()
-
     @validator("suite", pre=True)
     def _validate_suite(cls, v: dict | ExpectationSuite):
         # Input will be a dict of identifiers if being deserialized or a suite object if being constructed by a user.
@@ -233,12 +224,3 @@ def run(
             result_format=result_format,
         )
         return validator.validate_expectation_suite(self.suite, evaluation_parameters)
-
-    @public_api
-    def save(self) -> None:
-        key = self._store.get_key(name=self.name, id=self.id)
-
-        try:
-            self._store.update(key=key, value=self)
-        except gx_exceptions.StoreBackendError:
-            raise ValueError("ValidationConfig must be added to a store before saving.")

tests/core/test_validation_config.py

@@ -497,28 +497,3 @@ def test_validation_config_deserialization_non_existant_resource(
     ):
         with pytest.raises(ValueError, match=f"{error_substring}*."):
             ValidationConfig.parse_obj(serialized_config)
-
-
-@pytest.mark.unit
-def test_validation_config_save_success(
-    ephemeral_context: EphemeralDataContext, validation_config: ValidationConfig
-):
-    context = ephemeral_context
-    vc = validation_config
-
-    vc = context.validations.add(vc)
-
-    other_suite = ExpectationSuite(name="my_other_suite")
-    vc.suite = other_suite
-    vc.save()
-
-    assert vc.suite == other_suite
-    assert context.validations.get(vc.name).suite == other_suite
-
-
-@pytest.mark.unit
-def test_validation_config_save_failure(validation_config: ValidationConfig):
-    with pytest.raises(
-        ValueError, match="ValidationConfig must be added to a store before saving."
-    ):
-        validation_config.save()