[MAINTENANCE] Refactor EmailAction for V1
#9725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
Apr 9, 2024
| @@ -130,3 +130,26 @@ def test_EmailRenderer_get_report_element(): | |||
|
|
|||
| # this should work | |||
| assert email_renderer._get_report_element(docs_link="i_should_work") is not None | |||
|
|
|||
|
|
|||
| @pytest.mark.unit | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9725 +/- ##
========================================
Coverage 82.63% 82.64%
========================================
Files 512 512
Lines 46594 46630 +36
========================================
+ Hits 38504 38537 +33
- Misses 8090 8093 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tyler-hoffman
approved these changes
Apr 9, 2024
| out = action.v1_run(checkpoint_result=checkpoint_result) | ||
|
|
||
| mock_send_email.assert_called_once_with( | ||
| title=mock.ANY, |
There was a problem hiding this comment.
I think ANY makes sense here, but I might add another assertion below to verify that the argument passed kind of looks like the right string. (e.g. suite_name in call_args.kwargs["title"] (or whatever the syntax is for that))
…_expectations into m/v1-251/email_action
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update action and renderer to use checkpoint result
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!