Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINTENANCE] Refactor
EmailAction
for V1 #9725[MAINTENANCE] Refactor
EmailAction
for V1 #9725Changes from 4 commits
f2fe218
7f886f7
148deb3
e22abd2
b61c207
0080e12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 794 in great_expectations/checkpoint/actions.py
Codecov / codecov/patch
great_expectations/checkpoint/actions.py#L794
Check warning on line 14 in great_expectations/render/renderer/email_renderer.py
Codecov / codecov/patch
great_expectations/render/renderer/email_renderer.py#L13-L14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ANY makes sense here, but I might add another assertion below to verify that the argument passed kind of looks like the right string. (e.g.
suite_name in call_args.kwargs["title"]
(or whatever the syntax is for that))There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.