Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove [cloud] optional dependency #9813

Merged
merged 12 commits into from
Apr 29, 2024
3 changes: 1 addition & 2 deletions reqs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Requirements
- **reqs/requirements-dev-contrib.txt**: Mostly linting tools like `black`, `mypy`, and `ruff`
- **reqs/requirements-dev-all-contrib-expectations.txt**: The requirements for all of the contrib Expectations; only used in CI when building the Expectation Gallery
- **reqs/requirements-dev-api-docs-test.txt**: Just `docstring-parser` package needed for generating API docs
- **reqs/requirements-dev-cloud.txt**: `great_expectations_cloud` and any related deps to get Cloud functional; `pip install ".[cloud]"`
JennyTee marked this conversation as resolved.
Show resolved Hide resolved
- **reqs/requirements-dev-cloud.txt**: dependencies needed for GX Cloud; `pip install ".[cloud]"`
- **reqs/requirements-dev-spark.txt**: `pip install ".[spark]"`
- **reqs/requirements-dev-arrow.txt**: `pip install ".[arrow]"`
- **reqs/requirements-dev-azure.txt**: `pip install ".[azure]"` and `pip install ".[azure_secrets]"`
Expand All @@ -24,7 +24,6 @@ Requirements
- reqs/requirements-dev-lite.txt
- reqs/requirements-dev-contrib.txt
- reqs/requirements-dev-api-docs-test.txt
- reqs/requirements-dev-cloud.txt
JennyTee marked this conversation as resolved.
Show resolved Hide resolved
- **reqs/requirements-dev-sqlalchemy.txt**: Includes every requirements file for every sqlalchemy dialect; should not do `pip install -r reqs/requirements-dev-sqlalchemy.txt`
- reqs/requirements-dev-lite.txt
- reqs/requirements-dev-sqlalchemy1.txt
Expand Down
1 change: 0 additions & 1 deletion reqs/requirements-dev-cloud.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
great_expectations_cloud>=0.0.3.dev5
orjson>=3.9.7
4 changes: 2 additions & 2 deletions tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ def docs(
ctx.run(" ".join(["yarn lint"]), echo=True)
elif version:
docs_builder = DocsBuilder(ctx, docusaurus_dir)
docs_builder.create_version(version=parse_version(version)) # type: ignore[arg-type]
docs_builder.create_version(version=parse_version(version))
elif start:
ctx.run(" ".join(["yarn start"]), echo=True)
elif clear:
Expand Down Expand Up @@ -920,7 +920,7 @@ def _get_marker_dependencies(markers: str | Sequence[str]) -> list[TestDependenc
iterable=["markers", "requirements_dev"],
help={
"markers": "Optional marker to install dependencies for. Can be specified multiple times.",
"requirements_dev": "Short name of `requirements-dev-*.txt` file to install, e.g. test, spark, cloud etc. Can be specified multiple times.", # noqa: E501
JennyTee marked this conversation as resolved.
Show resolved Hide resolved
"requirements_dev": "Short name of `requirements-dev-*.txt` file to install, e.g. test, spark, cloud, etc. Can be specified multiple times.", # noqa: E501
"constraints": "Optional flag to install dependencies with constraints, default True",
},
)
Expand Down
6 changes: 3 additions & 3 deletions tests/test_deprecation.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import glob
import re
from typing import List, Pattern, Tuple, cast
from typing import List, Pattern, Tuple

import pytest
from packaging import version
Expand Down Expand Up @@ -79,7 +79,7 @@ def test_deprecation_warnings_have_been_removed_after_two_minor_versions(
with open(deployment_version_path) as f:
current_version = f.read().strip()

current_parsed_version: version.Version = cast(version.Version, version.parse(current_version))
JennyTee marked this conversation as resolved.
Show resolved Hide resolved
current_parsed_version: version.Version = version.parse(current_version)
current_major_version: int = current_parsed_version.major
current_minor_version: int = current_parsed_version.minor

Expand All @@ -90,7 +90,7 @@ def test_deprecation_warnings_have_been_removed_after_two_minor_versions(

matches: List[str] = regex_for_deprecation_comments.findall(contents)
for match in matches:
parsed_version: version.Version = cast(version.Version, version.parse(match))
parsed_version: version.Version = version.parse(match)
major_version: int = parsed_version.major
minor_version: int = parsed_version.minor
if (current_major_version - major_version > 0) and (
Expand Down