Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove [cloud] optional dependency #9813

Merged
merged 12 commits into from Apr 29, 2024

Conversation

JennyTee
Copy link
Contributor

@JennyTee JennyTee commented Apr 25, 2024

Jira ticket: https://greatexpectations.atlassian.net/browse/Z2-289

Removing the optional [cloud] dependency so that we can pin the agent to a specific GX Core version (or at least a minimum version) in pyproject.toml rather than just poetry.lock.

Similar PR into 0.18.x is here: #9814

This PR needs to be merged before we merge great-expectations/cloud#229.

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

@JennyTee JennyTee self-assigned this Apr 25, 2024
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for niobium-lead-7998 canceled.

Name Link
🔨 Latest commit bc6a87b
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/662bc7ca144c2a0008ba2d15

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.44%. Comparing base (71570a9) to head (bc6a87b).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9813   +/-   ##
========================================
  Coverage    82.44%   82.44%           
========================================
  Files          505      505           
  Lines        45399    45399           
========================================
+ Hits         37427    37428    +1     
+ Misses        7972     7971    -1     
Flag Coverage Δ
3.10 65.62% <ø> (ø)
3.10 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.10 aws_deps ?
3.10 big ?
3.10 databricks ?
3.10 filesystem ?
3.10 mssql ?
3.10 mysql ?
3.10 postgresql ?
3.10 snowflake ?
3.10 spark ?
3.10 trino ?
3.11 65.62% <ø> (+<0.01%) ⬆️
3.11 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.06% <ø> (ø)
3.11 aws_deps 44.22% <ø> (ø)
3.11 big 60.95% <ø> (ø)
3.11 databricks 45.01% <ø> (ø)
3.11 filesystem 61.54% <ø> (ø)
3.11 mssql 47.95% <ø> (ø)
3.11 mysql 48.00% <ø> (ø)
3.11 postgresql 51.48% <ø> (ø)
3.11 snowflake 45.56% <ø> (ø)
3.11 spark 57.00% <ø> (ø)
3.11 trino 50.96% <ø> (ø)
3.8 65.63% <ø> (ø)
3.8 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds 53.07% <ø> (ø)
3.8 aws_deps 44.23% <ø> (ø)
3.8 big 60.95% <ø> (ø)
3.8 databricks 45.02% <ø> (ø)
3.8 filesystem 61.56% <ø> (ø)
3.8 mssql 47.93% <ø> (ø)
3.8 mysql 47.99% <ø> (ø)
3.8 postgresql 51.47% <ø> (ø)
3.8 snowflake 45.58% <ø> (-0.01%) ⬇️
3.8 spark 56.95% <ø> (ø)
3.8 trino 50.95% <ø> (ø)
3.9 65.63% <ø> (ø)
3.9 athena or clickhouse or openpyxl or pyarrow or project or sqlite or aws_creds ?
3.9 aws_deps ?
3.9 big ?
3.9 databricks ?
3.9 filesystem ?
3.9 mssql ?
3.9 mysql ?
3.9 postgresql ?
3.9 snowflake ?
3.9 spark ?
3.9 trino ?
cloud 0.00% <ø> (ø)
docs-basic 51.80% <ø> (ø)
docs-creds-needed 52.72% <ø> (ø)
docs-spark 51.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JennyTee JennyTee marked this pull request as ready for review April 25, 2024 20:16
Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great we are removing the cloud repo as a dependency of great_expectations, thanks!
I have some comments because it seems like we still need the cloud dependency file for some metrics storage functionality.

reqs/README.md Show resolved Hide resolved
reqs/README.md Show resolved Hide resolved
reqs/README.md Outdated Show resolved Hide resolved
tasks.py Show resolved Hide resolved
CONTRIBUTING_CODE.md Outdated Show resolved Hide resolved
@JennyTee JennyTee requested a review from billdirks April 26, 2024 15:27
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

Copy link
Contributor

@billdirks billdirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JennyTee JennyTee added this pull request to the merge queue Apr 29, 2024
Merged via the queue into develop with commit 925d972 Apr 29, 2024
68 checks passed
@JennyTee JennyTee deleted the f/z2-289/remove-cloud-optional-dependency branch April 29, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants