New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Remove [cloud] optional dependency #9813
Conversation
✅ Deploy Preview for niobium-lead-7998 canceled.
|
This reverts commit 4b56c29.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9813 +/- ##
========================================
Coverage 82.44% 82.44%
========================================
Files 505 505
Lines 45399 45399
========================================
+ Hits 37427 37428 +1
+ Misses 7972 7971 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is great we are removing the cloud repo as a dependency of great_expectations, thanks!
I have some comments because it seems like we still need the cloud dependency file for some metrics storage functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Jira ticket: https://greatexpectations.atlassian.net/browse/Z2-289
Removing the optional [cloud] dependency so that we can pin the agent to a specific GX Core version (or at least a minimum version) in pyproject.toml rather than just poetry.lock.
Similar PR into
0.18.x
is here: #9814This PR needs to be merged before we merge great-expectations/cloud#229.
invoke lint
(usesruff format
+ruff check
)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!