Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove [cloud] optional dependency #9814

Merged
merged 5 commits into from
Apr 29, 2024
Merged

[FEATURE] Remove [cloud] optional dependency #9814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcc7ec8
remove [cloud] optional dependency
JennyTee Apr 25, 2024
e33e46a
re-add requirements-dev-cloud.txt file
JennyTee Apr 25, 2024
39361b2
apply updates per PR comments on develop PR
JennyTee Apr 26, 2024
fef17ec
reorder
JennyTee Apr 26, 2024
7ef4174
re-add dependency
JennyTee Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions reqs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Requirements
- **reqs/requirements-dev-contrib.txt**: Mostly linting tools like `black`, `mypy`, and `ruff`
- **reqs/requirements-dev-all-contrib-expectations.txt**: The requirements for all of the contrib Expectations; only used in CI when building the Expectation Gallery
- **reqs/requirements-dev-api-docs-test.txt**: Just `docstring-parser` package needed for generating API docs
- **reqs/requirements-dev-cloud.txt**: `great_expectations_cloud` and any related deps to get Cloud functional; `pip install ".[cloud]"`
- **reqs/requirements-dev-cloud.txt**: dependencies needed for GX Cloud; `pip install ".[cloud]"`
- **reqs/requirements-dev-spark.txt**: `pip install ".[spark]"`
- **reqs/requirements-dev-arrow.txt**: `pip install ".[arrow]"`
- **reqs/requirements-dev-azure.txt**: `pip install ".[azure]"` and `pip install ".[azure_secrets]"`
Expand All @@ -24,7 +24,6 @@ Requirements
- reqs/requirements-dev-lite.txt
- reqs/requirements-dev-contrib.txt
- reqs/requirements-dev-api-docs-test.txt
- reqs/requirements-dev-cloud.txt
- **reqs/requirements-dev-sqlalchemy.txt**: Includes every requirements file for every sqlalchemy dialect; should not do `pip install -r reqs/requirements-dev-sqlalchemy.txt`
- reqs/requirements-dev-lite.txt
- reqs/requirements-dev-sqlalchemy1.txt
Expand Down
1 change: 0 additions & 1 deletion reqs/requirements-dev-cloud.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
great_expectations_cloud>=0.0.3.dev5
orjson>=3.9.7
2 changes: 1 addition & 1 deletion tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ def _get_marker_dependencies(markers: str | Sequence[str]) -> list[TestDependenc
iterable=["markers", "requirements_dev"],
help={
"markers": "Optional marker to install dependencies for. Can be specified multiple times.",
"requirements_dev": "Short name of `requirements-dev-*.txt` file to install, e.g. test, spark, cloud etc. Can be specified multiple times.",
"requirements_dev": "Short name of `requirements-dev-*.txt` file to install, e.g. test, spark, cloud, etc. Can be specified multiple times.",
"constraints": "Optional flag to install dependencies with constraints, default True",
},
)
Expand Down