[FEATURE] Remove [cloud] optional dependency #9814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JennyTee
commented
Apr 25, 2024
| @@ -1,2 +1 @@ | |||
| great_expectations_cloud>=0.0.3.dev5 | |||
| orjson>=3.9.7 | |||
There was a problem hiding this comment.
Initially I tried to remove this whole file...but cloud_data_store.py needs orjson for the tests that are run in the develop branch.
Keeping it in this branch, too, for consistency. (Even though CI passed without it.)
anthonyburdi
approved these changes
Apr 26, 2024
Kilo59
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://greatexpectations.atlassian.net/browse/Z2-289
Removing the optional [cloud] dependency so that we can pin the agent to a specific GX Core version (or at least a minimum version) in pyproject.toml rather than just poetry.lock.
Similar PR into
developis here: #9813This PR needs to be merged before we can merge great-expectations/cloud#229.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!