Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix segmented story #77

Merged
merged 1 commit into from
May 9, 2024
Merged

fix segmented story #77

merged 1 commit into from
May 9, 2024

Conversation

1i1it
Copy link
Contributor

@1i1it 1i1it commented May 7, 2024

Before:
image

After:
image

@gx-cla-bot
Copy link

gx-cla-bot bot commented May 7, 2024

A new contributor, HUZZAH! Welcome and thanks for joining our community. In order to accept a pull request we require that all contributors sign our Contributor License Agreement. We have two different CLAs, depending on whether you are contributing to GX in a personal or professional capacity. Please sign the one that is applicable to your situation so that we may accept your contribution:

Individual Contributor License Agreement v1.0
Software Grant and Corporate Contributor License Agreement v1.0

Once you have signed the CLA, you can add a comment with the text @cla-bot check and the bot will update the PR status!

Please reach out to the #gx-community-support channel, on our Slack if you have any questions or if you have already signed the CLA and are receiving this message in error.

Users missing a CLA: 1i1it

@1i1it 1i1it requested a review from DrewHoo May 7, 2024 20:36
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.78%. Comparing base (768d8c4) to head (80cc293).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #77   +/-   ##
=======================================
  Coverage   76.78%   76.78%           
=======================================
  Files          36       36           
  Lines         435      435           
  Branches       75       75           
=======================================
  Hits          334      334           
  Misses         77       77           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1i1it
Copy link
Contributor Author

1i1it commented May 7, 2024

@cla-bot check SLA signed

Copy link
Contributor

@DrewHoo DrewHoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@1i1it 1i1it merged commit 4929254 into main May 9, 2024
4 of 5 checks passed
@1i1it 1i1it deleted the m/update-segmented-story branch May 9, 2024 06:23
Copy link

🎉 This PR is included in version 1.15.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants