-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone SonarQube plugin #14
Conversation
f84542d
to
6c7fdf3
Compare
6c7fdf3
to
e405b69
Compare
sonar-plugin/src/main/java/io/ecocode/javascript/JavaScriptRulesDefinition.java
Outdated
Show resolved
Hide resolved
sonar-plugin/src/main/java/io/ecocode/javascript/TypeScriptRulesDefinition.java
Outdated
Show resolved
Hide resolved
Those identifiers are currently not used. So no problem in my opinion to use these. |
I have added those rules into: green-code-initiative/ecoCode#178 |
@utarwyn : if you want, you can remove rule specification files (in <dependency>
<groupId>io.ecocode</groupId>
<artifactId>ecocode-rules-specifications</artifactId>
<version>0.0.1</version>
<classifier>javascript</classifier>
</dependency> Also, I think you can make a PR to |
Nice idea! Thank you for the artifact, I will try and create a new PR with the change
Yes I have planned to remove the javascript-plugin inside ecoCode right after this one will be merged |
@dedece35 I have answered all your remarks/questions I think 😄 |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for me, now.
Description
Its time to take the ecoCode JavaScript plugin to the next level! 🚀
The main objective of this PR is to create a standard SonarQube plugin that can be integrated into their marketplace.
Thanks to these changes, both plugins can now run completely independently. Rules are both displayed in the SonarQube interface and reported by ESLint. Boom! 💥
I'm taking the opportunity to move the SonarQube plugin from the main repository.
Changes
Actual / After
Actual 🐌🐌
Rules are loaded as external rules (more info here), so they are not displayed in the interface. They also can't be enabled/disabled or added to a quality profile. Users must manually install the ESLint plugin inside JS projects and update properties of the analyzer to include the ESLint report.
After 🔥🔥
The SonarQube plugin packs everything! No more manual task needed: rules are displayed in the interface like others. ESLint plugin can still be used alone in a project that does not use SonarQube.
Related Issues
Resolves #12