-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run ID is now accessible even after fail and thus can be sent via ema… #601
Conversation
…il; Refactorings for private attributes
Old Energy EstimationEco-CI Output:
📈 Energy graph:
7.65 ┤ ╭╮
7.06 ┤ ╭─╮ ╭╮ ││
6.47 ┤ │ │ ││ ││ ╭╮
5.88 ┤ │ │ ││ │╰╮││
5.30 ┤ ╭╮╭╮ │ │ ╭╯╰─╮ │ ╰╯│
4.71 ┤ ││││ ╭╮╭─╮ │ ╰─╮╭───╮ ╭╯ │ │ │
4.12 ┤ ╭╮╭─╯╰╯╰╮╭╮╭─╮╭──╮╭──╮ ╭─╮ ╭───╮╭╯╰╯ │╭──╮ │ ╰╯ ╰╮ │ ╰╮ │ │ ╭╮ ╭╮╭─╮ ╭──╮╭─╮╭─╮ ╭─╮╭╮ ╭╮╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭─╮╭╮ ╭─╮ ╭╮╭─╮ ╭╮╭╮ ╭╮╭╮ ╭─╮ ╭╮ ╭╮ ╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮
3.53 ┤ ╭╮│╰╯ ╰╯╰╯ ││ ╰╯ ╰──╯ ╰──╮╭╯ ╰╯ ╰╯ │ ╭╮ │ │ │ │ │ │ ╭╯│ │││ ╰─╮ ╭─╮ ╭╮ ╭─╯ ╰╯ ╰╯ ╰─╯ ╰╯│ │││╰╮ │╰╯│ ╭─╯│ ╭─╯│ ╭─╯│ ╭───╮ ╭╯╰╮ ╭╯╰╮ ╭─╯╰╮ ╭───╮ │ ╰╯│ ╭╮ ╭╮╭──╯ │ ╭╮ │╰╯ │ ╭╮ ╭╯╰╯│ ╭─╮ ╭╮ ╭╯╰╯│ ╭╮ ╭╮ │ ╰─╮ ││╭╮ ╭╮╭─╯╰─╮ ╭╮╭╮ ╭╮╭───╮ │╰╮ │╰╯│ │╰╮ ╭╯│ ╭╯╰─╮ ╭╮ ╭╮╭╮ ╭─╯│ ╭╮ ╭──╮ ╭╮ ╭─╯╰─╯╰─╮ ╭╮ ╭╮ ╭─╮
2.94 ┤ │││ ╰╯ ││ ╰╮││ ╭╮╭╯ │ │ ╰─╯ │ ╭╯ │ │││ │ ╭╮│ │ │╰╮│ │ │╰╯ │ ╭╯ │ │ │ │ │ │ ╰╮ │ │ │ │ │ │ │ │ │ │ │ │ ││ │││ ╰╮ ╭╮ ││ │ │ ╭╮ ││ │ │ ╭╯ │ ││ │ ╰╮ ╭╯╰╮ ││ │ │ ││││ ╭╯││ │ ││││ ╭╯││ │ ╭╯ │ │ │ ╭╯ │ │ │ │ │ │╰╮││││ │ ╰╮ │╰─╮ │ │ ││╭╮ │ │ ││╭╮ │╰╮│ │
2.36 ┤ │╰╯ ││ │││ ╭╯╰╯ │ │ ╰╮ │ ╰─╯╰╯ │ │││ ╰─╮ ╭╮ │ ││ │ │ │ │ │ │ │ │ │ │ │ │ │ │ │ ╭╯ │ │ │ │ │ │ │ ││ ╭╯││ │ ││ ││ │ ╰╮ ││ ││ │ │ ╭─╯ │ ││ │ │ ╭╮│ │ ││ │ │ ╭─╯│││ │ ││ │ ╭╯│││ │ ││ │ │ │ ╭╯ │ │ │ │ ╰╮ │ │ ╭─╯ ╰╯│││ ╭╮ │ │ ╭╮│ │ │ │ ╭╯│││ │ │ ╭─╯│││ │ ││ ╰╮
1.77 ┼──────╯ ╰╯ ╰╯╰─╯ ╰───╯ ╰──────╯ ╰───────╯╰╯ ╰──╯╰───╯ ╰╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰─────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰─────────╯ ╰─────────╯╰───────╯ ╰╯ ╰────────╯╰────────╯╰─╯ ╰────────╯╰────────╯╰─╯ ╰────────╯ ╰────────╯╰─╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰────────╯ ╰╯╰───────╯ ╰╯ ╰─────────╯ ╰╯╰───────╯ ╰╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰─────────╯ ╰────────╯ ╰────────╯ ╰╯╰───────╯╰─╯ ╰───────╯╰╯ ╰──────────╯ ╰─────────╯ ╰╯╰─────────╯ ╰────────╯ ╰╯╰───────╯ ╰╯ ╰────────
Watts over time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Not a big fan of adding more global vars but as we use this anyway this seems the easiest solution
global var? What do you mean? |
|
Eco-CI Output:
📈 Energy graph:
7.78 ┤ ╭╮ ╭╮
7.18 ┤ ││ ││
6.58 ┤ ││ ││
5.97 ┤ │╰╮ ╭─╮ │╰╮╭╮
5.37 ┤ ╭╮ │ │ ╭╯ ╰╮ │ ╰╯│
4.77 ┤ ││ ╭╮ │ ╰╮╭─╮╭╮ │ │ │ │
4.17 ┤ ╭╯╰─╮ ╭─╮ ╭──╮ ╭─╮ │╰╮ ╭╯ ╰╯ ╰╯╰╮ │ ╰╮│ │ ╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮ ╭────╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮
3.57 ┤ ╭╮╭──╯ ╰──╯ ╰────╯ ╰───────╯ ╰──────╯ ╰─╮ ╭─╯ │ │ ╰╯ │ ││╭╯││╰─╮ ╭╮ ╭╮ ╭───╯╰─────╯╰─╯╰──╮ ╭──╮ ╭╮╭─╮ ╭╮╭─╮ ╭──╮ ╭──╮╭────╯ ╰──────╮╭────────╮ │╰─╮ ╭──╮ ╭──╮ ╭──╮ ╭───╮ ╭╯╰─╮ ╭╮ ╭╮╭─╯╰─╮ ╭╮ ╭╯╰─╮ ╭╮╭─╯╰─╮ ╭╮╭╮ ╭╮ ╭╯╰─╮ ╭╮ ╭╮╭─╯╰─╮ ╭─╮ ╭╮ ╭╯╰─╮ ╭╮╭╮ ╭╮ ╭──╮ ╭──╮ │╰─╮ ╭─╮ ╭─╮ │╰──╮ ╭─╮╭╮╭╮ ╭───╮ ╭─╮ ╭──╮ ╭─╮ ╭─╯╰─────╮ ╭╮ ╭╮ ╭─
2.97 ┤ │││ ╰─╮ │ ╰╮ ╭╯ │ ╭╯╰╯ ││ │ ╭╯│╭╮ │╰╮│ │ │ │ │╰╯ │ │╰╯ │ ╭╯ │ │ ││ ││ │ │ ╰╮ │ ╰╮ │ ╰╮ │ │ │ │ │ │ ││ ╭╯││ │ ╭╮ ││╭╯ │ ╭╮ │││ │ ││││ ││ │ │ ││╭╮ │││ │ │ ╰╮ ││ │ ╰╮ ││││ ││ │ │ │ │ │ ╰╮ │ │ ╭╯ │ │ │ │ │││││ │ │ │ │ │ │ │ │ │ │ │╰─╮ ││╭╯
2.37 ┤ │││ ╰╮╭╯ │ ╭╯ │ │ ││ │ │ ╰╯│ │ ││ │ ╭╯ ╰╮ │ │ │ │ │ │ ╭╯ ││ ││ │ ╭╯ │ │ │ │ │ │ ╰╮ ╭╮│ │ ╭╯ │ ││ │ ││ ╰╮ ││ ╭╯││ │ ││ ╭╯││ │ ╭─╯╰╯│ ││ │ │ ╭─╯╰╯│ ╭╯││ │ ╭╮│ │ ││ │ │ ╭╮│╰╯│ ││ │ ╰╮ │ │ │ │ ╭╯ │ │ │ ╭╯ │ ╭╮│ ││╰╯│ │ │ ╭╮│ ╰╮ │ ╰╮ ╭╮│ ╰╮ │ │ ╭╮│ │ ╭╯││
1.77 ┼──────╯╰╯ ╰╯ ╰─╯ ╰───────╯ ╰╯ ╰─────────╯ ╰───────╯ ╰╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰╯ ╰╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰────────╯ ╰──────╯╰╯ ╰────────╯ ╰─────────╯╰───────╯ ╰╯ ╰────────╯╰───────╯ ╰╯ ╰─────────╯╰───────╯ ╰╯ ╰────────╯ ╰────────╯╰─╯ ╰────────╯ ╰───────╯ ╰╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰───────╯╰╯ ╰────────╯╰─╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰─────────╯ ╰────────╯ ╰───────╯╰╯ ╰╯ ╰──────────╯ ╰───────╯╰╯ ╰──────────╯ ╰───────╯╰╯ ╰──────────╯ ╰───────╯╰╯ ╰───────╯ ╰╯
Watts over time |
I'll explain on the phone. Nothing that stops the merge. |
* main: (26 commits) Disable tinyproxy systemd service (#623) Text change Value formatting on status page Normalized URL for machines endpoint Less confusing error messages Status has now a waiting time (#599) Run ID is now accessible even after fail and thus can be sent via ema… (#601) Switched from cmd to command (#615) Hotfix for check on frequency provider Tests run_until must be guard-claused with cleanup routine (#616) Fix check if stderr is empty (#613) Bump uvicorn[standard] from 0.24.0.post1 to 0.25.0 (#612) Fxing the network provider stderror Branch and filename are now always not null (#602) Adds a more elaborate depends_on test Support reading notes from services (#590) docker build command in tests now checks reason for docker build failure. If it is a permission issue with the cache, it will continue the rest of the workflow (#576) Use depends_on for container startup order (refactored) (#593) Bump psycopg[binary] from 3.1.15 to 3.1.16 (#610) Added powercap info to hardware_info (#609) ...
This PR fixes the confusing email behaviour that sometimes this would be show:
Since the run_id could not be seen when a run was failed it would show up as None in the email.
This lead to the further complication that some email programs want to generate a link preview and access this URL. This lead to further error emails for 404 access and so on ...
Now run_id is always transported and if really not present then no link is shown