Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check if stderr is empty #613

Merged

Conversation

davidkopp
Copy link
Contributor

Commit 270463c by @ribalba lead to the following warnings:

/home/david/green-metrics-tool/runner.py:964: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if stderr_read is not None and str(stderr_read) is not '':
/home/david/green-metrics-tool/runner.py:1098: SyntaxWarning: "is not" with a literal. Did you mean "!="?
  if stderr_read is not None and str(stderr_read) is not '':

This PR fixes it.

@ribalba ribalba merged commit 32faa39 into green-coding-solutions:main Dec 21, 2023
@ribalba
Copy link
Member

ribalba commented Dec 21, 2023

Great thank you. I accidentally pushed to the wrong branch while on a train and then the internet was gone to fix it. Fix will be in another pr.

@davidkopp davidkopp deleted the fix-check-if-stderr-is-empty branch December 21, 2023 16:09
ArneTR added a commit that referenced this pull request Dec 22, 2023
* main:
  Switched from cmd to command (#615)
  Hotfix for check on frequency provider
  Tests run_until must be guard-claused with cleanup routine (#616)
  Fix check if stderr is empty (#613)
  Bump uvicorn[standard] from 0.24.0.post1 to 0.25.0 (#612)
  Fxing the network provider stderror
ArneTR added a commit that referenced this pull request Dec 22, 2023
* main:
  Hotfix for check on frequency provider
  Tests run_until must be guard-claused with cleanup routine (#616)
  Fix check if stderr is empty (#613)
  Bump uvicorn[standard] from 0.24.0.post1 to 0.25.0 (#612)
  Fxing the network provider stderror
  Branch and filename are now always not null (#602)
  Adds a more elaborate depends_on test
  Support reading notes from services (#590)
  docker build command in tests now checks reason for docker build failure. If it is a permission issue with the cache, it will continue the rest of the workflow (#576)
  Use depends_on for container startup order (refactored) (#593)
  Bump psycopg[binary] from 3.1.15 to 3.1.16 (#610)
  Added powercap info to hardware_info (#609)
  Changed wording for network infrastructure box (#608)
  Added SIGQUIT to nginx and initi to gunicorn, as we are using bash script in entrypoint (#605)
  Fix frontend flow menu to wrap automatically (#584)
  Bump psutil from 5.9.6 to 5.9.7 (#603)
  Disable Docker CLI hints (#555)
  Create codeql.yml
ArneTR added a commit that referenced this pull request Dec 23, 2023
* main: (26 commits)
  Disable tinyproxy systemd service (#623)
  Text change
  Value formatting on status page
  Normalized URL for machines endpoint
  Less confusing error messages
  Status has now a waiting time (#599)
  Run ID is now accessible even after fail and thus can be sent via ema… (#601)
  Switched from cmd to command (#615)
  Hotfix for check on frequency provider
  Tests run_until must be guard-claused with cleanup routine (#616)
  Fix check if stderr is empty (#613)
  Bump uvicorn[standard] from 0.24.0.post1 to 0.25.0 (#612)
  Fxing the network provider stderror
  Branch and filename are now always not null (#602)
  Adds a more elaborate depends_on test
  Support reading notes from services (#590)
  docker build command in tests now checks reason for docker build failure. If it is a permission issue with the cache, it will continue the rest of the workflow (#576)
  Use depends_on for container startup order (refactored) (#593)
  Bump psycopg[binary] from 3.1.15 to 3.1.16 (#610)
  Added powercap info to hardware_info (#609)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants