Template version #30
Merged
Template version #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
+ Coverage 40.57% 42.17% +1.6%
=========================================
Files 12 13 +1
Lines 456 524 +68
=========================================
+ Hits 185 221 +36
- Misses 271 303 +32
Continue to review full report at Codecov.
|
This will allow to improve checks on the installed git hook.
Just check if the installed git hook contains autohooks.precommit.
The module will be responsible for writing a pre commit hook and evaluating an existing pre commit hook.
Don't return the list of lines. Instead return the text as string as already specified with the typings.
''.split always returns a list of at least one element.
Make it obvious at first read that an error has occurred if authooks couldn't be loaded.
Return the path to the pre commit hook file when converting to string.
Add tests for PreCommitHook class and get_pre_commit_hook_path function.
Add a function for checking the pre commit hook and another one for checking the current config.
Use dot consistently in all messages.
These functions got replaced with using the PreCommitHook class.
These checks are only recommondations and should not raise errors.
When running the pre-commit hook check for the current hook version and the current mode.
Always use autohooks from itself.
wiegandm
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: