Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setuptools support #54

Merged
merged 11 commits into from Apr 9, 2020
Merged

Remove setuptools support #54

merged 11 commits into from Apr 9, 2020

Conversation

bjoernricks
Copy link
Member

@bjoernricks bjoernricks commented Apr 8, 2020

Checklist:

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #54 into master will decrease coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   51.63%   51.10%   -0.54%     
==========================================
  Files          14       13       -1     
  Lines         734      681      -53     
==========================================
- Hits          379      348      -31     
+ Misses        355      333      -22     
Impacted Files Coverage Δ
autohooks/config.py 98.24% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b9192...b0da090. Read the comment docs.

@bjoernricks bjoernricks marked this pull request as ready for review April 8, 2020 06:33
wiegandm
wiegandm previously approved these changes Apr 9, 2020
Copy link
Member

@wiegandm wiegandm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good to me.

I have made a small suggestions as I found that long options (like --upgrade instead of -U) do definitively help me when reviewing changes, especially if it is a command or an option I do not use on a daily basis.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
bjoernricks and others added 11 commits April 9, 2020 08:55
setup.py and MANIFEST.in are used by setuptools to build and install our
software.
Rely on [PEP 517](https://www.python.org/dev/peps/pep-0517/) and poetry
for installation.
Allow to display keyword on pypi for autohooks.
Add the markdown and poetry files to the source distributable (.tar.gz)
to allow reproducable builds with it.
This code has become obsolete after setuptools isn't used as build
system anymore and we are using poetry now. It isn't possible to install
the git hook automatically anymore.
We are not using setuptools anymore.
This class got introduced during the conversion to poetry lately and is
now obsolete because support of setuptools has been dropped. It was only
used for creating meta information in the setup.py file.
We don't use setuptools anymore.
Update deploy target for CircleCI to build and install also the wheel
distribution of the autohooks python package.
Use long option (`--update`) for updating pip via pip

Co-Authored-By: Michael Wiegand <wiegandm@users.noreply.github.com>
@bjoernricks bjoernricks merged commit b3dbf8c into greenbone:master Apr 9, 2020
@bjoernricks bjoernricks deleted the remove-setuptools-support branch April 9, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants