New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setuptools support #54
Remove setuptools support #54
Conversation
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 51.63% 51.10% -0.54%
==========================================
Files 14 13 -1
Lines 734 681 -53
==========================================
- Hits 379 348 -31
+ Misses 355 333 -22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themselves look good to me.
I have made a small suggestions as I found that long options (like --upgrade
instead of -U
) do definitively help me when reviewing changes, especially if it is a command or an option I do not use on a daily basis.
setup.py and MANIFEST.in are used by setuptools to build and install our software.
Rely on [PEP 517](https://www.python.org/dev/peps/pep-0517/) and poetry for installation.
Allow to display keyword on pypi for autohooks.
Add the markdown and poetry files to the source distributable (.tar.gz) to allow reproducable builds with it.
This code has become obsolete after setuptools isn't used as build system anymore and we are using poetry now. It isn't possible to install the git hook automatically anymore.
We are not using setuptools anymore.
This class got introduced during the conversion to poetry lately and is now obsolete because support of setuptools has been dropped. It was only used for creating meta information in the setup.py file.
We don't use setuptools anymore.
Update deploy target for CircleCI to build and install also the wheel distribution of the autohooks python package.
Use long option (`--update`) for updating pip via pip Co-Authored-By: Michael Wiegand <wiegandm@users.noreply.github.com>
Checklist: