Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setuptools support #54

Merged
merged 11 commits into from
Apr 9, 2020
Merged

Remove setuptools support #54

merged 11 commits into from
Apr 9, 2020

Commits on Apr 9, 2020

  1. Drop files for setuptools 

    setup.py and MANIFEST.in are used by setuptools to build and install our
software.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    75f7f0c View commit details
    Browse the repository at this point in the history

  2. Use poetry as build system too 

    Rely on [PEP 517](https://www.python.org/dev/peps/pep-0517/) and poetry
for installation.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    998abe0 View commit details
    Browse the repository at this point in the history

  3. Add keywords for package meta information 

    Allow to display keyword on pypi for autohooks.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    1399fd9 View commit details
    Browse the repository at this point in the history

  4. Add additional files to the source distributable 

    Add the markdown and poetry files to the source distributable (.tar.gz)
to allow reproducable builds with it.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    25149aa View commit details
    Browse the repository at this point in the history

  5. Remove the setuptools extensions 

    This code has become obsolete after setuptools isn't used as build
system anymore and we are using poetry now. It isn't possible to install
the git hook automatically anymore.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    56a601b View commit details
    Browse the repository at this point in the history

  6. Remove setuptools as direct dependency 

    We are not using setuptools anymore.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    84c65e4 View commit details
    Browse the repository at this point in the history

  7. Drop unused PoetryConfig class 

    This class got introduced during the conversion to poetry lately and is
now obsolete because support of setuptools has been dropped. It was only
used for creating meta information in the setup.py file.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    a92a7f6 View commit details
    Browse the repository at this point in the history

  8. It should not be necessary to update setuptools 

    We don't use setuptools anymore.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    6dc8971 View commit details
    Browse the repository at this point in the history

  9. Build and upload source and wheel distributions 

    Update deploy target for CircleCI to build and install also the wheel
distribution of the autohooks python package.
    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b1423d2 View commit details
    Browse the repository at this point in the history

  10. Add CHANGELOG entry for setuptools to poetry build switch

    @bjoernricks
    bjoernricks committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    ffce380 View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Use long option (`--update`) for updating pip via pip

Co-Authored-By: Michael Wiegand <wiegandm@users.noreply.github.com>
    @bjoernricks @wiegandm
    bjoernricks and wiegandm committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    b0da090 View commit details
    Browse the repository at this point in the history