Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for default hosts and os filters #1243

Merged
merged 7 commits into from
Apr 1, 2019

Conversation

swaterkamp
Copy link
Member

@swaterkamp swaterkamp commented Apr 1, 2019

Clean up some related code as well.
Needs greenbone/gvmd#447 to work.

Checklist:

  • [ N/A ] Tests
  • [ X ] CHANGES Entry

@swaterkamp swaterkamp self-assigned this Apr 1, 2019
@swaterkamp swaterkamp requested a review from a team April 1, 2019 13:09
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #1243 into gsa-8.0 will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1243      +/-   ##
===========================================
- Coverage    17.36%   17.35%   -0.01%     
===========================================
  Files          950      950              
  Lines        27621    27623       +2     
  Branches      5956     5957       +1     
===========================================
- Hits          4796     4795       -1     
- Misses       21381    21384       +3     
  Partials      1444     1444
Impacted Files Coverage Δ
gsa/src/web/pages/usersettings/filterpart.js 0% <ø> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <ø> (ø) ⬆️
gsa/src/web/pages/filters/component.js 0% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/dialog.js 0% <ø> (ø) ⬆️
gsa/src/gmp/commands/users.js 3.92% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/usersettingspage.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af5cbe...4cef870. Read the comment docs.

Co-Authored-By: swaterkamp <32056637+swaterkamp@users.noreply.github.com>
@bjoernricks bjoernricks merged commit e59dbfd into greenbone:gsa-8.0 Apr 1, 2019
@swaterkamp swaterkamp deleted the DefaultFilterAssets branch February 20, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants