Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New default filter settings #1326

Merged
merged 6 commits into from
Apr 26, 2019

Conversation

swaterkamp
Copy link
Member

Add default filter settings option for Groups, Users, Scanners, Tickets, and Vulnerabilities.

Also allow to create new Filters of the types Scanner, Ticket, and Vulnerability.

Checklist:

@swaterkamp swaterkamp requested review from bjoernricks and a team April 26, 2019 12:14
@swaterkamp swaterkamp self-assigned this Apr 26, 2019
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1326 into gsa-8.0 will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1326      +/-   ##
===========================================
- Coverage     34.4%   34.37%   -0.03%     
===========================================
  Files          958      958              
  Lines        21569    21584      +15     
  Branches      5970     5975       +5     
===========================================
  Hits          7420     7420              
- Misses       12790    12805      +15     
  Partials      1359     1359
Impacted Files Coverage Δ
gsa/src/web/pages/filters/component.js 8.33% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/filterpart.js 42.85% <ø> (ø) ⬆️
gsa/src/gmp/commands/users.js 5.45% <ø> (ø) ⬆️
gsa/src/web/pages/usersettings/usersettingspage.js 3.23% <0%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73b708d...becf296. Read the comment docs.

@bjoernricks bjoernricks merged commit 9489042 into greenbone:gsa-8.0 Apr 26, 2019
@swaterkamp swaterkamp deleted the NewFilterSettings branch April 26, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants