Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all filter strings to lower case #1444

Merged
merged 7 commits into from
Jun 19, 2019

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Jun 18, 2019

Amended FilterTerm to change all filter keywords to lowercase.
Checklist:

Copy link
Member

@swaterkamp swaterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry for that and edit the PR's checklist accordingly?

@saberlynx saberlynx requested a review from a team June 18, 2019 13:46
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1444 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   36.71%   36.71%           
=======================================
  Files         989      989           
  Lines       22185    22185           
  Branches     6087     6110   +23     
=======================================
  Hits         8145     8145           
  Misses      12715    12715           
  Partials     1325     1325
Impacted Files Coverage Δ
gsa/src/gmp/models/filter/filterterm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9201f0c...e3ee5fc. Read the comment docs.

@bjoernricks
Copy link
Contributor

Could you do me a favor and add two additional tests?

@swaterkamp swaterkamp merged commit a6507d6 into greenbone:master Jun 19, 2019
@saberlynx saberlynx deleted the filterlowercase branch June 19, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants