Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fields to tickets filter page #1489

Merged
merged 7 commits into from
Jul 18, 2019

Conversation

saberlynx
Copy link
Contributor

  • Replaced default filterdialog with custom one (and edited listpage to reflect this)
  • added ticketstatusgroup, severityvaluesgroup and solutiontypegroup to new filterdialog
  • added tests for ticketstatusgroup

Checklist:

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #1489 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage      37%   37.02%   +0.01%     
==========================================
  Files         996      998       +2     
  Lines       22255    22266      +11     
  Branches     6111     6137      +26     
==========================================
+ Hits         8236     8243       +7     
- Misses      12705    12709       +4     
  Partials     1314     1314
Impacted Files Coverage Δ
gsa/src/web/pages/tickets/listpage.js 33.33% <ø> (-9.53%) ⬇️
gsa/src/web/pages/tickets/filterdialog.js 40% <40%> (ø)
...rc/web/components/powerfilter/ticketstatusgroup.js 85.71% <85.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1518ef4...fb5039c. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review July 17, 2019 14:50
@bjoernricks bjoernricks merged commit b34110b into greenbone:master Jul 18, 2019
@saberlynx saberlynx deleted the ticketsFilter branch July 18, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants