Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secinfo filter from user settings dialog and elsewhere #2495

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

saberlynx
Copy link
Contributor

@saberlynx saberlynx commented Oct 6, 2020

What:

Remove the "Secinfo Filter" form part form user settings dialog and remove instances of the secInfoFilter variable. Also remove translations for that form field.

Why:

Because we no longer have all secinfo and it's confusing to leave that in the dialog.

How:

Tests are still passing and it is visually verified to be gone.

Checklist:

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #2495 into gsa-20.08 will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           gsa-20.08    #2495      +/-   ##
=============================================
+ Coverage      52.76%   53.07%   +0.30%     
=============================================
  Files           1070     1072       +2     
  Lines          25789    25892     +103     
  Branches        7312     7396      +84     
=============================================
+ Hits           13607    13741     +134     
+ Misses         11058    11029      -29     
+ Partials        1124     1122       -2     
Impacted Files Coverage Δ
gsa/src/gmp/commands/feedstatus.js 100.00% <ø> (ø)
gsa/src/gmp/commands/policies.js 86.15% <ø> (+1.67%) ⬆️
gsa/src/gmp/commands/scanconfigs.js 90.62% <ø> (+0.73%) ⬆️
gsa/src/gmp/commands/wizard.js 9.23% <ø> (ø)
gsa/src/gmp/gmpsettings.js 95.74% <ø> (ø)
gsa/src/gmp/models/alert.js 100.00% <ø> (ø)
gsa/src/gmp/models/event.js 22.91% <ø> (+2.17%) ⬆️
gsa/src/gmp/models/nvt.js 98.87% <ø> (ø)
gsa/src/gmp/models/ovaldef.js 94.64% <ø> (ø)
gsa/src/gmp/models/policy.js 100.00% <ø> (ø)
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7ed27e...cbf5003. Read the comment docs.

@saberlynx saberlynx marked this pull request as ready for review October 6, 2020 12:32
@saberlynx saberlynx requested review from a team, sarahd93 and swaterkamp October 6, 2020 12:32
@sarahd93 sarahd93 merged commit 87466ef into greenbone:gsa-20.08 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants